From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D80DC4338F for ; Mon, 2 Aug 2021 02:36:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7111D61042 for ; Mon, 2 Aug 2021 02:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231608AbhHBCgg (ORCPT ); Sun, 1 Aug 2021 22:36:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbhHBCgc (ORCPT ); Sun, 1 Aug 2021 22:36:32 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135CAC0613D3; Sun, 1 Aug 2021 19:36:23 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4GdMZP2s0Lz9sT6; Mon, 2 Aug 2021 12:36:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1627871780; bh=3h+pDmgdaEzjLhKsKsWflOl3eTtWNpO0qlqcc3HN5gw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=a1WosJ0KTXjCRMYjN+wSNFc6ThlMWt6oNtTvbiU08VVh18S12fqbdg7dtDkTBwLa5 mW8V1Rs4z1BYZuL+pODWPRcD9vbuP8wr01nokBcoTqy49p0SZolAkJwet6ROF0SgEd HIz4pn3qWuGGanDbWuW4js0/5hgiIlpoNRE/cyUZxz2eu0jNe7yDYVqAQscP9GPFnE qSf68THatsIhId+0A9UWQp8CymuJZBASivoSVD4ldWSNoXSko1yGGp69QbvPTzYUiQ G0ZV6Ba/iniZMiL5MNvLUDtAPk+yDPaeM5eVp48+0XyP3sN+LVB9D69GzgsiEom2l/ 2x/ybfb3/4spg== From: Michael Ellerman To: Masahiro Yamada , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org Cc: Masahiro Yamada , Will Deacon , Thomas Bogendoerfer , Palmer Dabbelt , Catalin Marinas , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> References: <20210731060020.12913-1-masahiroy@kernel.org> Date: Mon, 02 Aug 2021 12:36:08 +1000 Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro Yamada writes: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > arch/arm/vdso/Makefile | 4 ---- > arch/arm64/kernel/vdso/Makefile | 5 +---- > arch/arm64/kernel/vdso32/Makefile | 3 --- > arch/csky/kernel/vdso/Makefile | 4 +--- > arch/mips/vdso/Makefile | 2 -- > arch/powerpc/kernel/vdso32/Makefile | 14 ++++++-------- > arch/powerpc/kernel/vdso64/Makefile | 14 ++++++-------- I noticed this the other day and was puzzled why we still needed the conditional, thanks for cleaning it up. Acked-by: Michael Ellerman (powerpc) cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4873C4338F for ; Mon, 2 Aug 2021 02:37:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F67961050 for ; Mon, 2 Aug 2021 02:37:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9F67961050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+PTiADkBKdnOSoSKkZx/MVFHNVpOr3QpgvYuq9rqb+4=; b=r5Qz7iSnbnTbl9 veYYzi6cH3PBObDO7TdZps2WcHl398p0Qchw+hzqkdSz231buei6Z6uBKifavtlTaJyaju6C4uSIR 7eS7ehyZapzl1AauP529c8dGbc8lpyHPQAi+KXFe3qGms3fBuynw1W13X1Wvek+nVF7F0a31BCQbb tcpL6+lNYlgonp0H4eiXTWqooVoErdzXyfnUcJPmnsrUVxwc1I0UTQjOjIenk0emJDLnvP+Un0lou QBcSncdD7RTw4Hlgau/V4YKNtzDeJM7FlpGUti6womDikuLE35Rwhp4ORa6Per8b+gdlVjUWGDwMm i62UVBJRHAhzLrwbQzMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mANp4-00Ehxh-UP; Mon, 02 Aug 2021 02:36:58 +0000 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2] helo=ozlabs.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mANoY-00Ehut-Ps; Mon, 02 Aug 2021 02:36:28 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4GdMZP2s0Lz9sT6; Mon, 2 Aug 2021 12:36:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1627871780; bh=3h+pDmgdaEzjLhKsKsWflOl3eTtWNpO0qlqcc3HN5gw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=a1WosJ0KTXjCRMYjN+wSNFc6ThlMWt6oNtTvbiU08VVh18S12fqbdg7dtDkTBwLa5 mW8V1Rs4z1BYZuL+pODWPRcD9vbuP8wr01nokBcoTqy49p0SZolAkJwet6ROF0SgEd HIz4pn3qWuGGanDbWuW4js0/5hgiIlpoNRE/cyUZxz2eu0jNe7yDYVqAQscP9GPFnE qSf68THatsIhId+0A9UWQp8CymuJZBASivoSVD4ldWSNoXSko1yGGp69QbvPTzYUiQ G0ZV6Ba/iniZMiL5MNvLUDtAPk+yDPaeM5eVp48+0XyP3sN+LVB9D69GzgsiEom2l/ 2x/ybfb3/4spg== From: Michael Ellerman To: Masahiro Yamada , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org Cc: Masahiro Yamada , Will Deacon , Thomas Bogendoerfer , Palmer Dabbelt , Catalin Marinas , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> References: <20210731060020.12913-1-masahiroy@kernel.org> Date: Mon, 02 Aug 2021 12:36:08 +1000 Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210801_193627_139106_F5C49C16 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Masahiro Yamada writes: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > arch/arm/vdso/Makefile | 4 ---- > arch/arm64/kernel/vdso/Makefile | 5 +---- > arch/arm64/kernel/vdso32/Makefile | 3 --- > arch/csky/kernel/vdso/Makefile | 4 +--- > arch/mips/vdso/Makefile | 2 -- > arch/powerpc/kernel/vdso32/Makefile | 14 ++++++-------- > arch/powerpc/kernel/vdso64/Makefile | 14 ++++++-------- I noticed this the other day and was puzzled why we still needed the conditional, thanks for cleaning it up. Acked-by: Michael Ellerman (powerpc) cheers _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9EBC4338F for ; Mon, 2 Aug 2021 02:36:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65CC261050 for ; Mon, 2 Aug 2021 02:36:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 65CC261050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GdMb55D8vz30J0 for ; Mon, 2 Aug 2021 12:36:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=a1WosJ0K; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ellerman.id.au (client-ip=203.11.71.1; helo=ozlabs.org; envelope-from=mpe@ellerman.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=a1WosJ0K; dkim-atps=neutral Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GdMZZ44J5z2yLm for ; Mon, 2 Aug 2021 12:36:21 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4GdMZP2s0Lz9sT6; Mon, 2 Aug 2021 12:36:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1627871780; bh=3h+pDmgdaEzjLhKsKsWflOl3eTtWNpO0qlqcc3HN5gw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=a1WosJ0KTXjCRMYjN+wSNFc6ThlMWt6oNtTvbiU08VVh18S12fqbdg7dtDkTBwLa5 mW8V1Rs4z1BYZuL+pODWPRcD9vbuP8wr01nokBcoTqy49p0SZolAkJwet6ROF0SgEd HIz4pn3qWuGGanDbWuW4js0/5hgiIlpoNRE/cyUZxz2eu0jNe7yDYVqAQscP9GPFnE qSf68THatsIhId+0A9UWQp8CymuJZBASivoSVD4ldWSNoXSko1yGGp69QbvPTzYUiQ G0ZV6Ba/iniZMiL5MNvLUDtAPk+yDPaeM5eVp48+0XyP3sN+LVB9D69GzgsiEom2l/ 2x/ybfb3/4spg== From: Michael Ellerman To: Masahiro Yamada , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> References: <20210731060020.12913-1-masahiroy@kernel.org> Date: Mon, 02 Aug 2021 12:36:08 +1000 Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Bogendoerfer , Masahiro Yamada , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-csky@vger.kernel.org, Russell King , Albert Ou , Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, Paul Walmsley , Catalin Marinas , Guo Ren , linux-riscv@lists.infradead.org, Will Deacon , Paul Mackerras Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Masahiro Yamada writes: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > arch/arm/vdso/Makefile | 4 ---- > arch/arm64/kernel/vdso/Makefile | 5 +---- > arch/arm64/kernel/vdso32/Makefile | 3 --- > arch/csky/kernel/vdso/Makefile | 4 +--- > arch/mips/vdso/Makefile | 2 -- > arch/powerpc/kernel/vdso32/Makefile | 14 ++++++-------- > arch/powerpc/kernel/vdso64/Makefile | 14 ++++++-------- I noticed this the other day and was puzzled why we still needed the conditional, thanks for cleaning it up. Acked-by: Michael Ellerman (powerpc) cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DE6C4338F for ; Mon, 2 Aug 2021 02:38:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E1A461050 for ; Mon, 2 Aug 2021 02:38:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6E1A461050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SVVcmSRo8OO8scJiJsdrSEoWCGCVk8VlCvS7sEEfjGU=; b=yEIxyIPM8906OL Eg8n7mGiZhWsZsL156lPMOcd0pxMHmo0j7Ev/dhhHiunTU/JPvF0XFdKq1PYxsJlj87vcfCqBJbQV wVC9dJ9ew/yNl2sez9mssOb/aHNc/jE6B4yV+wZkDxuZmRtjrfNf2Bw5ux8vceZm8kDDcMQUKQ8cT Hc3Chy9HSn1In+Xl8EYpoD+epKxKpILMYHhp7MSPx/Pg5Krn1OjtFkCoMHkQRNztjENPXDOOjRYz8 YaFaD61O73b6CVYB3xvTs/okaBUBOnOdWcYA9u1ngX2pjOnbgdQ3qD7QC5t2b95P+HpccRRUSMWmp MCaRUEcVW3j26DAO9eTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mANoc-00Ehvj-Ho; Mon, 02 Aug 2021 02:36:30 +0000 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2] helo=ozlabs.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mANoY-00Ehut-Ps; Mon, 02 Aug 2021 02:36:28 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4GdMZP2s0Lz9sT6; Mon, 2 Aug 2021 12:36:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1627871780; bh=3h+pDmgdaEzjLhKsKsWflOl3eTtWNpO0qlqcc3HN5gw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=a1WosJ0KTXjCRMYjN+wSNFc6ThlMWt6oNtTvbiU08VVh18S12fqbdg7dtDkTBwLa5 mW8V1Rs4z1BYZuL+pODWPRcD9vbuP8wr01nokBcoTqy49p0SZolAkJwet6ROF0SgEd HIz4pn3qWuGGanDbWuW4js0/5hgiIlpoNRE/cyUZxz2eu0jNe7yDYVqAQscP9GPFnE qSf68THatsIhId+0A9UWQp8CymuJZBASivoSVD4ldWSNoXSko1yGGp69QbvPTzYUiQ G0ZV6Ba/iniZMiL5MNvLUDtAPk+yDPaeM5eVp48+0XyP3sN+LVB9D69GzgsiEom2l/ 2x/ybfb3/4spg== From: Michael Ellerman To: Masahiro Yamada , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org Cc: Masahiro Yamada , Will Deacon , Thomas Bogendoerfer , Palmer Dabbelt , Catalin Marinas , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> References: <20210731060020.12913-1-masahiroy@kernel.org> Date: Mon, 02 Aug 2021 12:36:08 +1000 Message-ID: <87v94ozi7b.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210801_193627_139106_F5C49C16 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Masahiro Yamada writes: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > arch/arm/vdso/Makefile | 4 ---- > arch/arm64/kernel/vdso/Makefile | 5 +---- > arch/arm64/kernel/vdso32/Makefile | 3 --- > arch/csky/kernel/vdso/Makefile | 4 +--- > arch/mips/vdso/Makefile | 2 -- > arch/powerpc/kernel/vdso32/Makefile | 14 ++++++-------- > arch/powerpc/kernel/vdso64/Makefile | 14 ++++++-------- I noticed this the other day and was puzzled why we still needed the conditional, thanks for cleaning it up. Acked-by: Michael Ellerman (powerpc) cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel