From: Felipe Balbi <balbi@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: USB mailing list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/4] USB: UDC: Implement udc_async_callbacks in dummy-hcd
Date: Fri, 04 Jun 2021 08:21:11 +0300 [thread overview]
Message-ID: <87v96ub3y0.fsf@kernel.org> (raw)
In-Reply-To: <20210520202152.GD1216852@rowland.harvard.edu>
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
Hi,
Alan Stern <stern@rowland.harvard.edu> writes:
> @@ -990,7 +1000,6 @@ static int dummy_udc_start(struct usb_ga
> spin_lock_irq(&dum->lock);
> dum->devstatus = 0;
> dum->driver = driver;
> - dum->ints_enabled = 1;
should the matching write of 0 be removed from dummy_udc_stop()?
Other than that:
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-06-04 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 20:21 [PATCH 2/4] USB: UDC: Implement udc_async_callbacks in dummy-hcd Alan Stern
2021-06-04 5:21 ` Felipe Balbi [this message]
2021-06-04 14:15 ` Alan Stern
2021-06-04 14:20 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v96ub3y0.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.