From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B7EC433ED for ; Fri, 9 Apr 2021 13:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93D4561056 for ; Fri, 9 Apr 2021 13:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233119AbhDINxF (ORCPT ); Fri, 9 Apr 2021 09:53:05 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:50876 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232395AbhDINxD (ORCPT ); Fri, 9 Apr 2021 09:53:03 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1617976368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlzmOVxwr4C/QvkXDWcabTiao9Ep+tBVADbOwAhH70o=; b=ja4zkQonmkR4bCQuaWge1rljj7nQO8IJFn+niJhCXPkyiJ6oSc7GwE6qScTItiDtdPFvBa jegD+lLkHL7uDGvzDdnAUSL0VFCcBr6Hbt58qgZNmkZwsqQBXB5kJVlvQ4DfxYI2xpI5lv SPk6NziWvSiXd+FhO0/gy+v4qqgcz/ZzW58j+HDGroGHm+rxDzETojf6xZDqS4V4zD/oum c5ODgmSYJX2MkJF8QKai2EzKswhT72ghaWnaFzT+isMRkSZzbu28hBlbw0DqFbx9ICeb/s pk/FAdFbXW9cSfL/QoKtkvai5yj6DSH9yJy/8gEemIihraaeyj9ip3PhTlPrnw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1617976368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlzmOVxwr4C/QvkXDWcabTiao9Ep+tBVADbOwAhH70o=; b=xzD+oJ4z+s5lAisCPoFhFJ78JG5yeERdbr9ybk3vTBbUneIoqtXh48jS3BfYLaQxJoGk6g yDi/qM8J54+q5CDA== To: Valentin Schneider , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH 05/10] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq() In-Reply-To: <20210408154326.3988781-6-valentin.schneider@arm.com> References: <20210408154326.3988781-1-valentin.schneider@arm.com> <20210408154326.3988781-6-valentin.schneider@arm.com> Date: Fri, 09 Apr 2021 15:52:48 +0200 Message-ID: <87v98v4lan.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 08 2021 at 16:43, Valentin Schneider wrote: > A subsequent patch will let IRQs end up in irq_finalize_oneshot() without > IRQD_IRQ_MASKED, but with IRQD_IRQ_FLOW_MASKED set instead. Let such IRQs > receive their final ->irq_eoi(). > > Signed-off-by: Valentin Schneider > --- > kernel/irq/manage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index e976c4927b25..59c8056d6714 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -1076,7 +1076,7 @@ static void irq_finalize_oneshot(struct irq_desc *desc, > desc->threads_oneshot &= ~action->thread_mask; > > if (!desc->threads_oneshot && !irqd_irq_disabled(&desc->irq_data) && > - irqd_irq_masked(&desc->irq_data)) > + (irqd_irq_masked(&desc->irq_data) || irqd_irq_flow_masked(&desc->irq_data))) > unmask_threaded_irq(desc); This creates better code when you have '|' instead of '||' because the compiler can spare a conditional and combine the bit check into one. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB60C433ED for ; Fri, 9 Apr 2021 13:54:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB9AE61108 for ; Fri, 9 Apr 2021 13:54:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB9AE61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/s2tm9qmbkBQTrB207xcsI5XX7JiOaYgcYtAoT9vuXM=; b=XNH205OBPs7VwOeGdlXPon0SR Loj9IPtndnlWSuQqc0EIgMmcscN6vs+UN+PA1Db+oxLLRvST3IHIRBhIqbHW4qVW/m+exMu64wlU2 vcwxe3vJfZsWlXNbJ4UVO79WCeCAlSgseQOoGVlgtv2DrmEBIS/iieM5bVxWxK28nMsD289Bso1rU 0o39gEXc9/hnAht2Lzm2NOCTWgrNa7UEcLt5xLauhaG9SjFx1OteqOyoLwI/r9h0+ohfeH/E7UrVQ ME5J/ScQXq4ar04c1z4rHQrLKwyf1VWMPwzSmpwX6UcXcWPL5u7xva7Mtd1l6GdNnvEOibZ+JSJ3f SKxKNYu8g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUrZ9-000raQ-Ja; Fri, 09 Apr 2021 13:52:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUrZ7-000raD-Pj for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 13:52:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tlzmOVxwr4C/QvkXDWcabTiao9Ep+tBVADbOwAhH70o=; b=vuyT07HeFZSCPCOEdfLDl1PAHH dJUheB9QDXx+c4K+Uu9y5B8GJ82X+H8EiQL5/Q+0s2zYam9vVKMeStwravpy7xMhEc/RWkPXsGis+ VQJBTkT10Rt3SBB3hOKjelA8RBPcqoshFmtKwALZOIyiMdHfGlhKQcAdsyQZJxCsTatRnhWf1eADR 6erYJtlK2c69npFB2Mxa/3FfGvrvPis4KbJDDnymaOuCWost7pVDEfvk9DAblW0anWH8affwgru4M NrSEnrGabVlLlhNRMVlz+naQqd9K2m/RAuEF5oRG/tCPdY3f2KhU8D+85UhieiZoM74Z/kxbGrrFG nFJtirAw==; Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUrZ5-004Z1i-1R for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 13:52:52 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1617976368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlzmOVxwr4C/QvkXDWcabTiao9Ep+tBVADbOwAhH70o=; b=ja4zkQonmkR4bCQuaWge1rljj7nQO8IJFn+niJhCXPkyiJ6oSc7GwE6qScTItiDtdPFvBa jegD+lLkHL7uDGvzDdnAUSL0VFCcBr6Hbt58qgZNmkZwsqQBXB5kJVlvQ4DfxYI2xpI5lv SPk6NziWvSiXd+FhO0/gy+v4qqgcz/ZzW58j+HDGroGHm+rxDzETojf6xZDqS4V4zD/oum c5ODgmSYJX2MkJF8QKai2EzKswhT72ghaWnaFzT+isMRkSZzbu28hBlbw0DqFbx9ICeb/s pk/FAdFbXW9cSfL/QoKtkvai5yj6DSH9yJy/8gEemIihraaeyj9ip3PhTlPrnw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1617976368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlzmOVxwr4C/QvkXDWcabTiao9Ep+tBVADbOwAhH70o=; b=xzD+oJ4z+s5lAisCPoFhFJ78JG5yeERdbr9ybk3vTBbUneIoqtXh48jS3BfYLaQxJoGk6g yDi/qM8J54+q5CDA== To: Valentin Schneider , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH 05/10] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq() In-Reply-To: <20210408154326.3988781-6-valentin.schneider@arm.com> References: <20210408154326.3988781-1-valentin.schneider@arm.com> <20210408154326.3988781-6-valentin.schneider@arm.com> Date: Fri, 09 Apr 2021 15:52:48 +0200 Message-ID: <87v98v4lan.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_065251_244985_29771074 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 08 2021 at 16:43, Valentin Schneider wrote: > A subsequent patch will let IRQs end up in irq_finalize_oneshot() without > IRQD_IRQ_MASKED, but with IRQD_IRQ_FLOW_MASKED set instead. Let such IRQs > receive their final ->irq_eoi(). > > Signed-off-by: Valentin Schneider > --- > kernel/irq/manage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index e976c4927b25..59c8056d6714 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -1076,7 +1076,7 @@ static void irq_finalize_oneshot(struct irq_desc *desc, > desc->threads_oneshot &= ~action->thread_mask; > > if (!desc->threads_oneshot && !irqd_irq_disabled(&desc->irq_data) && > - irqd_irq_masked(&desc->irq_data)) > + (irqd_irq_masked(&desc->irq_data) || irqd_irq_flow_masked(&desc->irq_data))) > unmask_threaded_irq(desc); This creates better code when you have '|' instead of '||' because the compiler can spare a conditional and combine the bit check into one. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel