All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/rauc: fix build with headers < 4.14
Date: Wed, 23 Dec 2020 10:09:45 +0100	[thread overview]
Message-ID: <87v9csj3c6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20201222111012.1641693-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Tue, 22 Dec 2020 12:10:12 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/829ae7ed66686c11a941ac99bd08a06f754affb4

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Thanks. I see that upstream mentions that this code will fail at runtime
with old kernels, so that is no good. Looking at the code I do see that
it explicitly ignores a failure to set the block size though.

I am not sure why it is so important to set to block size to 4k, and if
this is only for the new dm-verity based format.

I'll give upstream a bit of time to reply before handling this patch.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2020-12-23  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 11:10 [Buildroot] [PATCH 1/1] package/rauc: fix build with headers < 4.14 Fabrice Fontaine
2020-12-23  9:09 ` Peter Korsgaard [this message]
2020-12-23 12:15   ` Peter Korsgaard
2020-12-24  8:50 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9csj3c6.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.