From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5049BC4363C for ; Wed, 7 Oct 2020 11:36:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8A0F20782 for ; Wed, 7 Oct 2020 11:36:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z73W/oJM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8A0F20782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ7kY-00054n-LW for qemu-devel@archiver.kernel.org; Wed, 07 Oct 2020 07:36:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ7iq-00045g-Vf for qemu-devel@nongnu.org; Wed, 07 Oct 2020 07:35:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQ7io-0007CK-Vy for qemu-devel@nongnu.org; Wed, 07 Oct 2020 07:35:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602070502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AD6FZWvf6CnTwFdGsm1YFyYNRUDPJbA4VZ2JeHxFXNA=; b=Z73W/oJM/6NEehdpr85ABo25mB5GJQn30QojhxzRcvFb/DXC7w3WJulvDLiI+gMNleTXcx tEoJrTiG0swJ6SAfsPGbHn+YxGuKvv4J/7fCw4t9ckSxZUmro2QBMVUWMRbFgI9ItOEYvA aAj51NnJDHg4Mu3Jqk9EhuukxKw5Omo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-4Sl4PIw6ODW_7SkJ7jO0OA-1; Wed, 07 Oct 2020 07:34:59 -0400 X-MC-Unique: 4Sl4PIw6ODW_7SkJ7jO0OA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9807E80402A for ; Wed, 7 Oct 2020 11:34:58 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67A2F6EF5B; Wed, 7 Oct 2020 11:34:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id EAE9F11329C1; Wed, 7 Oct 2020 13:34:56 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH v5 21/36] qapi/commands.py: Don't re-bind to variable of different type References: <20201005195158.2348217-1-jsnow@redhat.com> <20201005195158.2348217-22-jsnow@redhat.com> Date: Wed, 07 Oct 2020 13:34:56 +0200 In-Reply-To: <20201005195158.2348217-22-jsnow@redhat.com> (John Snow's message of "Mon, 5 Oct 2020 15:51:43 -0400") Message-ID: <87v9fme0bj.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 00:54:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Mypy isn't a fan of rebinding a variable with a new data type. > It's easy enough to avoid. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/commands.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py > index f67393f8713..586774a23c7 100644 > --- a/scripts/qapi/commands.py > +++ b/scripts/qapi/commands.py > @@ -195,14 +195,12 @@ def gen_register_command(name, success_response, allow_oob, allow_preconfig): > if not options: > options = ['QCO_NO_OPTIONS'] > > - options = " | ".join(options) > - > ret = mcgen(''' > qmp_register_command(cmds, "%(name)s", > qmp_marshal_%(c_name)s, %(opts)s); > ''', > name=name, c_name=c_name(name), > - opts=options) > + opts=" | ".join(options)) > return ret Definitely neater. Reviewed-by: Markus Armbruster