From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05163C433E0 for ; Sat, 16 May 2020 11:11:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E696206D8 for ; Sat, 16 May 2020 11:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="N5FM2SDh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E696206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49PMyv11xfzDr0D for ; Sat, 16 May 2020 21:11:03 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49PMw65fWKzDqv4 for ; Sat, 16 May 2020 21:08:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=N5FM2SDh; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49PMw42VYhz9sTC; Sat, 16 May 2020 21:08:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1589627317; bh=xlRNdRKSs/1yt1XjZFyjzh4ZEGwNAvgrgcBi/dIj1sI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N5FM2SDhMEb3SpS16IWnzFxziXzH5MVUA9xzS6m/PFlG/VahrAZgwTLyGHOQ3HDkd eGBME/pgAkKCgcXhIKAjXpyVSbfJ5wsZ4rBYS3869ojTG2T/k7y3vW3ZhK0dJXauQg cs/YfaK5EoWTZsGIkrjH07PLO9KCxfRYwwhQJ1X4bkj3dRxun1E1TEdkdOKlOD4Buc 0FtkLBg0htXzrwwVOL1SHQIPd50vGDpQcHJfs7Gi19KYp8shU9LrzOR5B4GSFLfN7Y RJrZxqyCSVGkrnt/xFRKbeuFcpKTOrS+8n4T0yVIFhiHX6+PQcaXh2DHxoMJI0Y1ih tzQPi1Wi4gB/Q== From: Michael Ellerman To: Jordan Niethe , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 08/30] powerpc: Use a function for getting the instruction op code In-Reply-To: References: <20200506034050.24806-1-jniethe5@gmail.com> <20200506034050.24806-9-jniethe5@gmail.com> Date: Sat, 16 May 2020 21:08:56 +1000 Message-ID: <87v9kw9lx3.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , Alistair Popple , Nicholas Piggin , Balamuruhan S , naveen.n.rao@linux.vnet.ibm.com, Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Jordan Niethe writes: > mpe, as suggested by Christophe could you please add this. I did that and ... > diff --git a/arch/powerpc/include/asm/inst.h b/arch/powerpc/include/asm/inst.h > --- a/arch/powerpc/include/asm/inst.h > +++ b/arch/powerpc/include/asm/inst.h > @@ -2,6 +2,8 @@ > #ifndef _ASM_INST_H > #define _ASM_INST_H > > +#include .. this eventually breaks the build in some driver, because get_ra() is redefined. So I've backed out this change for now. If we want to use the macros in disassemble.h we'll need to namespace them better, eg. make them ppc_get_ra() and so on. cheers > /* > * Instruction data type for POWER > */ > @@ -15,7 +17,7 @@ static inline u32 ppc_inst_val(u32 x) > > static inline int ppc_inst_primary_opcode(u32 x) > { > - return ppc_inst_val(x) >> 26; > + return get_op(ppc_inst_val(x)); > } > > #endif /* _ASM_INST_H */ > -- > 2.17.1