From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 04/12] drm/i915: Extract BXT DIMM helpers Date: Mon, 04 Mar 2019 20:26:53 +0200 Message-ID: <87va0y3382.fsf@intel.com> References: <20190225202907.731-5-ville.syrjala@linux.intel.com> <20190226152717.4495-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93F4089D99 for ; Mon, 4 Mar 2019 18:24:52 +0000 (UTC) In-Reply-To: <20190226152717.4495-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyNiBGZWIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBQb2xpc2ggdGhlIGJ4dCBESU1NIHBhcnNpbmcgYnkgZXh0cmFj dGluZyBhIGZldyBzbWFsbCBoZWxwZXJzLgo+Cj4gdjI6IFVzZSBzdHJ1Y3QgZHJhbV9kaW1tX2lu Zm8KPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVs LmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCA5MyArKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYyIGluc2Vy dGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5k ZXggZDg0ZjM0ODVlNzc1Li5mOTQ4ZDQ3NWJkZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmMKPiBAQCAtMTI0Myw2ICsxMjQzLDU5IEBAIHNrbF9nZXRfZHJhbV9pbmZvKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtzdGF0aWMg aW50IGJ4dF9nZXRfZGltbV9zaXplKHUzMiB2YWwpCj4gK3sKPiArCXN3aXRjaCAodmFsICYgQlhU X0RSQU1fU0laRV9NQVNLKSB7Cj4gKwljYXNlIEJYVF9EUkFNX1NJWkVfNEdCOgo+ICsJCXJldHVy biA0Owo+ICsJY2FzZSBCWFRfRFJBTV9TSVpFXzZHQjoKPiArCQlyZXR1cm4gNjsKPiArCWNhc2Ug QlhUX0RSQU1fU0laRV84R0I6Cj4gKwkJcmV0dXJuIDg7Cj4gKwljYXNlIEJYVF9EUkFNX1NJWkVf MTJHQjoKPiArCQlyZXR1cm4gMTI7Cj4gKwljYXNlIEJYVF9EUkFNX1NJWkVfMTZHQjoKPiArCQly ZXR1cm4gMTY7Cj4gKwlkZWZhdWx0Ogo+ICsJCU1JU1NJTkdfQ0FTRSh2YWwpOwo+ICsJCXJldHVy biAwOwo+ICsJfQo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGJ4dF9nZXRfZGltbV93aWR0aCh1MzIg dmFsKQo+ICt7Cj4gKwlpZiAoIWJ4dF9nZXRfZGltbV9zaXplKHZhbCkpCj4gKwkJcmV0dXJuIDA7 Cj4gKwo+ICsJdmFsID0gKHZhbCAmIEJYVF9EUkFNX1dJRFRIX01BU0spID4+IEJYVF9EUkFNX1dJ RFRIX1NISUZUOwo+ICsKPiArCXJldHVybiA4IDw8IHZhbDsKPiArfQo+ICsKPiArc3RhdGljIGlu dCBieHRfZ2V0X2RpbW1fcmFua3ModTMyIHZhbCkKPiArewo+ICsJaWYgKCFieHRfZ2V0X2RpbW1f c2l6ZSh2YWwpKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXN3aXRjaCAodmFsICYgQlhUX0RSQU1f UkFOS19NQVNLKSB7Cj4gKwljYXNlIEJYVF9EUkFNX1JBTktfU0lOR0xFOgo+ICsJCXJldHVybiAx Owo+ICsJY2FzZSBCWFRfRFJBTV9SQU5LX0RVQUw6Cj4gKwkJcmV0dXJuIDI7Cj4gKwlkZWZhdWx0 Ogo+ICsJCU1JU1NJTkdfQ0FTRSh2YWwpOwo+ICsJCXJldHVybiAwOwo+ICsJfQo+ICt9Cj4gKwo+ ICtzdGF0aWMgdm9pZCBieHRfZ2V0X2RpbW1faW5mbyhzdHJ1Y3QgZHJhbV9kaW1tX2luZm8gKmRp bW0sCj4gKwkJCSAgICAgIHUzMiB2YWwpCj4gK3sKPiArCWRpbW0tPnNpemUgPSBieHRfZ2V0X2Rp bW1fc2l6ZSh2YWwpOwo+ICsJZGltbS0+d2lkdGggPSBieHRfZ2V0X2RpbW1fd2lkdGgodmFsKTsK PiArCWRpbW0tPnJhbmtzID0gYnh0X2dldF9kaW1tX3JhbmtzKHZhbCk7Cj4gK30KPiArCj4gIHN0 YXRpYyBpbnQKPiAgYnh0X2dldF9kcmFtX2luZm8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICB7Cj4gQEAgLTEyNzEsNDEgKzEzMjQsMTkgQEAgYnh0X2dldF9kcmFtX2luZm8o c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJICogTm93IHJlYWQgZWFjaCBE VU5JVDgvOS8xMC8xMSB0byBjaGVjayB0aGUgcmFuayBvZiBlYWNoIGRpbW1zLgo+ICAJICovCj4g IAlmb3IgKGkgPSBCWFRfRF9DUl9EUlAwX0RVTklUX1NUQVJUOyBpIDw9IEJYVF9EX0NSX0RSUDBf RFVOSVRfRU5EOyBpKyspIHsKPiAtCQl1OCBzaXplLCB3aWR0aCwgcmFua3M7Cj4gLQkJdTMyIHRt cDsKPiArCQlzdHJ1Y3QgZHJhbV9kaW1tX2luZm8gZGltbTsKPiAgCj4gIAkJdmFsID0gSTkxNV9S RUFEKEJYVF9EX0NSX0RSUDBfRFVOSVQoaSkpOwo+ICAJCWlmICh2YWwgPT0gMHhGRkZGRkZGRikK PiAgCQkJY29udGludWU7Cj4gIAo+ICAJCWRyYW1faW5mby0+bnVtX2NoYW5uZWxzKys7Cj4gLQkJ dG1wID0gdmFsICYgQlhUX0RSQU1fUkFOS19NQVNLOwo+IC0KPiAtCQlpZiAodG1wID09IEJYVF9E UkFNX1JBTktfU0lOR0xFKQo+IC0JCQlyYW5rcyA9IDE7Cj4gLQkJZWxzZSBpZiAodG1wID09IEJY VF9EUkFNX1JBTktfRFVBTCkKPiAtCQkJcmFua3MgPSAyOwo+IC0JCWVsc2UKPiAtCQkJcmFua3Mg PSAwOwo+IC0KPiAtCQl0bXAgPSB2YWwgJiBCWFRfRFJBTV9TSVpFX01BU0s7Cj4gLQkJaWYgKHRt cCA9PSBCWFRfRFJBTV9TSVpFXzRHQikKPiAtCQkJc2l6ZSA9IDQ7Cj4gLQkJZWxzZSBpZiAodG1w ID09IEJYVF9EUkFNX1NJWkVfNkdCKQo+IC0JCQlzaXplID0gNjsKPiAtCQllbHNlIGlmICh0bXAg PT0gQlhUX0RSQU1fU0laRV84R0IpCj4gLQkJCXNpemUgPSA4Owo+IC0JCWVsc2UgaWYgKHRtcCA9 PSBCWFRfRFJBTV9TSVpFXzEyR0IpCj4gLQkJCXNpemUgPSAxMjsKPiAtCQllbHNlIGlmICh0bXAg PT0gQlhUX0RSQU1fU0laRV8xNkdCKQo+IC0JCQlzaXplID0gMTY7Cj4gLQkJZWxzZQo+IC0JCQlz aXplID0gMDsKPiAtCj4gLQkJdG1wID0gKHZhbCAmIEJYVF9EUkFNX1dJRFRIX01BU0spID4+IEJY VF9EUkFNX1dJRFRIX1NISUZUOwo+IC0JCXdpZHRoID0gKDEgPDwgdG1wKSAqIDg7Cj4gLQkJRFJN X0RFQlVHX0tNUygiZHJhbSBzaXplOiVkR0Igd2lkdGg6WCVkIHJhbmtzOiVkXG4iLAo+IC0JCQkg ICAgICBzaXplLCB3aWR0aCwgcmFua3MpOwo+ICsKPiArCQlieHRfZ2V0X2RpbW1faW5mbygmZGlt bSwgdmFsKTsKPiArCj4gKwkJRFJNX0RFQlVHX0tNUygiQ0glZCBESU1NIHNpemU6ICVkIEdCLCB3 aWR0aDogWCVkLCByYW5rczogJWRcbiIsCj4gKwkJCSAgICAgIGkgLSBCWFRfRF9DUl9EUlAwX0RV TklUX1NUQVJULAo+ICsJCQkgICAgICBkaW1tLnNpemUsIGRpbW0ud2lkdGgsIGRpbW0ucmFua3Mp Owo+ICAKPiAgCQkvKgo+ICAJCSAqIElmIGFueSBvZiB0aGUgY2hhbm5lbCBpcyBzaW5nbGUgcmFu ayBjaGFubmVsLAo+IEBAIC0xMzEzLDggKzEzNDQsOCBAQCBieHRfZ2V0X2RyYW1faW5mbyhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJICogbWVtb3J5LCBzbyBjb25zaWRl ciBzaW5nbGUgcmFuayBtZW1vcnkuCj4gIAkJICovCj4gIAkJaWYgKGRyYW1faW5mby0+cmFua3Mg PT0gMCkKPiAtCQkJZHJhbV9pbmZvLT5yYW5rcyA9IHJhbmtzOwo+IC0JCWVsc2UgaWYgKHJhbmtz ID09IDEpCj4gKwkJCWRyYW1faW5mby0+cmFua3MgPSBkaW1tLnJhbmtzOwo+ICsJCWVsc2UgaWYg KGRpbW0ucmFua3MgPT0gMSkKPiAgCQkJZHJhbV9pbmZvLT5yYW5rcyA9IDE7Cj4gIAl9CgotLSAK SmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=