From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751670AbdGaUyN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 31 Jul 2017 16:54:13 -0400
Received: from mail.parknet.co.jp ([210.171.160.6]:52336 "EHLO
        mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751535AbdGaUyM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Jul 2017 16:54:12 -0400
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin()
References: <20170731143349.84629-1-andriy.shevchenko@linux.intel.com>
        <877eyov49l.fsf@devron> <87zibktpil.fsf@devron>
        <CAHp75Vd1gTFuw+ubDpe94uiooakNVHUf0cHDtsoop8dhOBKo9w@mail.gmail.com>
Date: Tue, 01 Aug 2017 05:54:09 +0900
In-Reply-To: <CAHp75Vd1gTFuw+ubDpe94uiooakNVHUf0cHDtsoop8dhOBKo9w@mail.gmail.com>
        (Andy Shevchenko's message of "Mon, 31 Jul 2017 22:31:29 +0300")
Message-ID: <87vam8tjim.fsf@devron>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

>> +
>> +                               *(wchar_t *)op = uc[0] << 8 | uc[1];
>> +
>> +                               op += 2;
>
> This had been in the original patch 6 years ago and had been refused
> because of endianess issues.

Sorry, I forgot what I said completely. Maybe I changed my mind? 

			if (uni_xlate == 1) {
				*op++ = ':';
				op = hex_byte_pack(op, ec >> 8);
				op = hex_byte_pack(op, ec);
				len -= 5;

Here is output. So "uc[0] << 8 | uc[1]" is right code, isn't it?

>>                                 charlen = nls->char2uni(ip, len - i,
>> -                                                                       (wchar_t *)op);
>> +                                                       (wchar_t *)op);
>
> It perfectly fits one line.

It over 80 column.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>