From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934390AbdBQPFx (ORCPT ); Fri, 17 Feb 2017 10:05:53 -0500 Received: from mga14.intel.com ([192.55.52.115]:18860 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933885AbdBQPFv (ORCPT ); Fri, 17 Feb 2017 10:05:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="935111671" From: Alexander Shishkin To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, kim.phillips@arm.com, alex.bennee@linaro.org, christoffer.dall@linaro.org, tglx@linutronix.de, peterz@infradead.org, robh@kernel.org, suzuki.poulose@arm.com, pawel.moll@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end In-Reply-To: <20170217144255.GI15431@arm.com> References: <1485540470-11469-1-git-send-email-will.deacon@arm.com> <1485540470-11469-8-git-send-email-will.deacon@arm.com> <8737fdj5q0.fsf@ashishki-desk.ger.corp.intel.com> <20170217140001.GD15431@arm.com> <87y3x4j4ho.fsf@ashishki-desk.ger.corp.intel.com> <20170217144255.GI15431@arm.com> User-Agent: Notmuch/0.23.5 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 17 Feb 2017 16:59:24 +0200 Message-ID: <87vas8j22b.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will Deacon writes: > On Fri, Feb 17, 2017 at 04:06:59PM +0200, Alexander Shishkin wrote: >> Will Deacon writes: >> >> > On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote: >> >> Will Deacon writes: >> >> >> >> > @@ -485,7 +485,8 @@ int intel_bts_interrupt(void) >> >> > return handled; >> >> > >> >> > perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0), >> >> > - !!local_xchg(&buf->lost, 0)); >> >> > + local_xchg(&buf->lost, 0) ? >> >> > + PERF_AUX_FLAG_OVERWRITE : 0); >> >> >> >> Heh, this one would have taken some time to debug. :) >> > >> > Don't worry, this isn't a bug fix! This patch changes the prototype for >> > perf_aux_output_end so that it takes the flag instead of a "bool truncated" >> > parameter, so this is just fixing up the callers at the same time. >> >> Yeah, I got that, what I'm saying is that the above should be >> PERF_AUX_FLAG_TRUNCATED, not OVERWRITE. I only spotted it by accident. > > D'oh, quite right, I'll fix that now. Thanks for having a look. Wait a bit with the fixing, I'm about to post an amended version. Regards, -- Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexander.shishkin@linux.intel.com (Alexander Shishkin) Date: Fri, 17 Feb 2017 16:59:24 +0200 Subject: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end In-Reply-To: <20170217144255.GI15431@arm.com> References: <1485540470-11469-1-git-send-email-will.deacon@arm.com> <1485540470-11469-8-git-send-email-will.deacon@arm.com> <8737fdj5q0.fsf@ashishki-desk.ger.corp.intel.com> <20170217140001.GD15431@arm.com> <87y3x4j4ho.fsf@ashishki-desk.ger.corp.intel.com> <20170217144255.GI15431@arm.com> Message-ID: <87vas8j22b.fsf@ashishki-desk.ger.corp.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Will Deacon writes: > On Fri, Feb 17, 2017 at 04:06:59PM +0200, Alexander Shishkin wrote: >> Will Deacon writes: >> >> > On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote: >> >> Will Deacon writes: >> >> >> >> > @@ -485,7 +485,8 @@ int intel_bts_interrupt(void) >> >> > return handled; >> >> > >> >> > perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0), >> >> > - !!local_xchg(&buf->lost, 0)); >> >> > + local_xchg(&buf->lost, 0) ? >> >> > + PERF_AUX_FLAG_OVERWRITE : 0); >> >> >> >> Heh, this one would have taken some time to debug. :) >> > >> > Don't worry, this isn't a bug fix! This patch changes the prototype for >> > perf_aux_output_end so that it takes the flag instead of a "bool truncated" >> > parameter, so this is just fixing up the callers at the same time. >> >> Yeah, I got that, what I'm saying is that the above should be >> PERF_AUX_FLAG_TRUNCATED, not OVERWRITE. I only spotted it by accident. > > D'oh, quite right, I'll fix that now. Thanks for having a look. Wait a bit with the fixing, I'm about to post an amended version. Regards, -- Alex