From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Tue, 13 Dec 2016 23:32:19 +0100 Subject: [Buildroot] [PATCH 3/3] [RFC] package/busybox: gneerate permissions for enabeld applets In-Reply-To: <6d7c0fcf8647fa6e554e32e0370baec848b9ddef.1481665059.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Tue, 13 Dec 2016 22:37:47 +0100") References: <6d7c0fcf8647fa6e554e32e0370baec848b9ddef.1481665059.git.yann.morin.1998@free.fr> Message-ID: <87vaun1mvg.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: > DO NOT COMMIT THIS. > This is jsut an example how to use FOO_PERMISSIONS_FILE. > Signed-off-by: "Yann E. MORIN" > --- > package/busybox/busybox.mk | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk > index f4a241d..9c1f2e8 100644 > --- a/package/busybox/busybox.mk > +++ b/package/busybox/busybox.mk > @@ -60,9 +60,24 @@ BUSYBOX_KCONFIG_FRAGMENT_FILES = $(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG_FRAG > BUSYBOX_KCONFIG_EDITORS = menuconfig xconfig gconfig > BUSYBOX_KCONFIG_OPTS = $(BUSYBOX_MAKE_OPTS) > +ifeq ($(BR2_PACKAGE_BUSYBOX_INDIVIDUAL_BINARIES),y) > +BUSYBOX_PERMISSIONS_FILE = $(@D)/busybox.permissions Careful, what does $(@D) refer to here? When it is used here in the file it is output/build/busybox-*, but when it is expanded in fs/common.mk it refers to output/images: cat /home/peko/source/buildroot/output-test/images/busybox.permissions >> /home/peko/source/buildroot/output-test/build/_device_table.txt cat: /home/peko/source/buildroot/output-test/images/busybox.permissions: No such file or directory > +define BUSYBOX_GEN_PERMISSIONS > + for app in `grep -r -e "APPLET.*BB_SUID_REQUIRE\|APPLET.*BB_SUID_MAYBE" $(@D)/include/applets.h \ > + | sed -e 's/,.*//' -e 's/.*(//'`; \ > + do \ > + temp=`grep -w $${app} $(@D)/busybox.links`; \ > + if [ -n "$${temp}" ]; then \ > + echo "$${temp} f 4755 0 0 - - - - -" You forgot to append ; \ so it doesn't actually work. -- Bye, Peter Korsgaard