All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Daniel Vetter" <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove AGP dependency from DRM_I915 kconfig help text
Date: Mon, 24 Oct 2016 17:07:17 +0300	[thread overview]
Message-ID: <87vawhon6y.fsf@intel.com> (raw)
In-Reply-To: <20161024100902.GD4617@intel.com>

On Mon, 24 Oct 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Oct 24, 2016 at 10:52:59AM +0200, Daniel Vetter wrote:
>> On Fri, Oct 21, 2016 at 12:14:17PM +0300, Jani Nikula wrote:
>> > We haven't required AGP since 3e99a6b95614 ("drm/i915: Stop depending
>> > upon CONFIG_AGP_INTEL"). Split/rearrange the paragraphs a bit while at
>> > it.
>> > 
>> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> 
>> > ---
>> >  drivers/gpu/drm/i915/Kconfig | 11 ++++++-----
>> >  1 file changed, 6 insertions(+), 5 deletions(-)
>> > 
>> > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>> > index 1c1b19ccb92f..45a5eb71e8e6 100644
>> > --- a/drivers/gpu/drm/i915/Kconfig
>> > +++ b/drivers/gpu/drm/i915/Kconfig
>> > @@ -24,16 +24,17 @@ config DRM_I915
>> >  	  including 830M, 845G, 852GM, 855GM, 865G, 915G, 945G, 965G,
>> >  	  G35, G41, G43, G45 chipsets and Celeron, Pentium, Core i3,
>> >  	  Core i5, Core i7 as well as Atom CPUs with integrated graphics.
>> 
>> Hm, nowadays it's called Intel HD graphics. Maybe we should mention that?
>> Feel free to add that.
>
> HD graphics seems to be listed before the chipset names. But we do lack
> a mention of the "Exterme Graphics" :) moniker that was used for gen2 IIRC.

Pushed as-is, thanks for the review.

BR,
Jani.

>
>> 
>> > -	  If M is selected, the module will be called i915.  AGP support
>> > -	  is required for this driver to work. This driver is used by
>> > -	  the Intel driver in X.org 6.8 and XFree86 4.4 and above. It
>> > -	  replaces the older i830 module that supported a subset of the
>> > -	  hardware in older X.org releases.
>> > +
>> > +	  This driver is used by the Intel driver in X.org 6.8 and
>> > +	  XFree86 4.4 and above. It replaces the older i830 module that
>> > +	  supported a subset of the hardware in older X.org releases.
>> >  
>> >  	  Note that the older i810/i815 chipsets require the use of the
>> >  	  i810 driver instead, and the Atom z5xx series has an entirely
>> >  	  different implementation.
>> >  
>> > +	  If "M" is selected, the module will be called i915.
>> > +
>> >  config DRM_I915_PRELIMINARY_HW_SUPPORT
>> >  	bool "Enable preliminary support for prerelease Intel hardware by default"
>> >  	depends on DRM_I915
>> > -- 
>> > 2.1.4
>> > 
>> 
>> -- 
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> http://blog.ffwll.ch
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2016-10-24 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  9:14 [PATCH] drm/i915: remove AGP dependency from DRM_I915 kconfig help text Jani Nikula
2016-10-21  9:47 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-24  8:52 ` [PATCH] " Daniel Vetter
2016-10-24 10:09   ` Ville Syrjälä
2016-10-24 14:07     ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vawhon6y.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.