From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1briFe-0001wl-6e for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1briFZ-0000W1-5e for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:12:33 -0400 From: Juan Quintela In-Reply-To: <1473390856-4502-2-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 8 Sep 2016 22:14:14 -0500") References: <1473390856-4502-1-git-send-email-eblake@redhat.com> <1473390856-4502-2-git-send-email-eblake@redhat.com> Reply-To: quintela@redhat.com Date: Wed, 05 Oct 2016 11:12:23 +0200 Message-ID: <87vax7tb0o.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, ashijeetacharya@gmail.com, qemu-stable@nongnu.org, Luiz Capitulino Eric Blake wrote: > Commit 69ef1f3 accidentally broke migrate_set_parameter's ability > to set the cpu-throttle-increment to anything other than the > default, because it forgot to parse the user's string into an > integer. > > CC: qemu-stable@nongnu.org > Signed-off-by: Eric Blake > --- > hmp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hmp.c b/hmp.c > index ad33b44..d6c6c01 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -1286,6 +1286,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > break; > case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT: > has_cpu_throttle_increment = true; > + use_int_value = true; > break; > case MIGRATION_PARAMETER_TLS_CREDS: > has_tls_creds = true; Reviewed-by: Juan Quintela