From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754384AbcFPTSW (ORCPT ); Thu, 16 Jun 2016 15:18:22 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:50791 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256AbcFPTSU (ORCPT ); Thu, 16 Jun 2016 15:18:20 -0400 X-Auth-Info: Bs1MM8HbhUxU6FE4rnGLX9I0px3EmzmLiQ4AZU2/r3rWgUcJ/GVVEqwX/HLyTMva From: Andreas Schwab To: Peter Zijlstra Cc: Geert Uytterhoeven , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Will Deacon , Paul McKenney , boqun.feng@gmail.com, waiman.long@hpe.com, =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , "linux-kernel\@vger.kernel.org" , Linux-Arch , Richard Henderson , Vineet Gupta , Russell King , Hans-Christian Noren Egtvedt , Miao Steven , Yoshinori Sato , Richard Kuo , Tony Luck , James Hogan , Ralf Baechle , David Howells , "James E.J. Bottomley" , Michael Ellerman , Martin Schwidefsky , Rich Felker , "David S. Miller" , cmetcalf@mellanox.com, Max Filippov , Arnd Bergmann , dbueso@suse.de, Wu Fengguang , linux-m68k Subject: Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() References: <20160531102642.333689893@infradead.org> <20160616101309.GD30921@twins.programming.kicks-ass.net> <20160616124949.GF30921@twins.programming.kicks-ass.net> <20160616143530.GG30921@twins.programming.kicks-ass.net> <20160616145653.GH30921@twins.programming.kicks-ass.net> <20160616174421.GK30921@twins.programming.kicks-ass.net> X-Yow: Content: 80% POLYESTER, 20% DACRON.. The waitress's UNIFORM sheds TARTAR SAUCE like an 8'' by 10'' GLOSSY.. Date: Thu, 16 Jun 2016 21:18:06 +0200 In-Reply-To: <20160616174421.GK30921@twins.programming.kicks-ass.net> (Peter Zijlstra's message of "Thu, 16 Jun 2016 19:44:21 +0200") Message-ID: <87vb19oscx.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not broken, so nothing to fix. > > Its non obvious code, that's usually plenty reason to change it. You appear to be the only one who has a problem with that documented construct. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Date: Thu, 16 Jun 2016 21:18:06 +0200 Message-ID: <87vb19oscx.fsf@linux-m68k.org> References: <20160531102642.333689893@infradead.org> <20160616101309.GD30921@twins.programming.kicks-ass.net> <20160616124949.GF30921@twins.programming.kicks-ass.net> <20160616143530.GG30921@twins.programming.kicks-ass.net> <20160616145653.GH30921@twins.programming.kicks-ass.net> <20160616174421.GK30921@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:50791 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256AbcFPTSU (ORCPT ); Thu, 16 Jun 2016 15:18:20 -0400 In-Reply-To: <20160616174421.GK30921@twins.programming.kicks-ass.net> (Peter Zijlstra's message of "Thu, 16 Jun 2016 19:44:21 +0200") Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Geert Uytterhoeven , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Will Deacon , Paul McKenney , boqun.feng@gmail.com, waiman.long@hpe.com, =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , "linux-kernel@vger.kernel.org" , Linux-Arch , Richard Henderson , Vineet Gupta , Russell King , Hans-Christian Noren Egtvedt , Miao Steven , Yoshinori Sato , Richard Kuo , Tony Luck , James Hogan , Ralf Baechle , David Howells Ja Peter Zijlstra writes: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not broken, so nothing to fix. > > Its non obvious code, that's usually plenty reason to change it. You appear to be the only one who has a problem with that documented construct. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net ([212.18.0.9]:50791 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256AbcFPTSU (ORCPT ); Thu, 16 Jun 2016 15:18:20 -0400 From: Andreas Schwab Subject: Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() References: <20160531102642.333689893@infradead.org> <20160616101309.GD30921@twins.programming.kicks-ass.net> <20160616124949.GF30921@twins.programming.kicks-ass.net> <20160616143530.GG30921@twins.programming.kicks-ass.net> <20160616145653.GH30921@twins.programming.kicks-ass.net> <20160616174421.GK30921@twins.programming.kicks-ass.net> Date: Thu, 16 Jun 2016 21:18:06 +0200 In-Reply-To: <20160616174421.GK30921@twins.programming.kicks-ass.net> (Peter Zijlstra's message of "Thu, 16 Jun 2016 19:44:21 +0200") Message-ID: <87vb19oscx.fsf@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Geert Uytterhoeven , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Will Deacon , Paul McKenney , boqun.feng@gmail.com, waiman.long@hpe.com, =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , "linux-kernel@vger.kernel.org" , Linux-Arch , Richard Henderson , Vineet Gupta , Russell King , Hans-Christian Noren Egtvedt , Miao Steven , Yoshinori Sato , Richard Kuo , Tony Luck , James Hogan , Ralf Baechle , David Howells , "James E.J. Bottomley" , Michael Ellerman , Martin Schwidefsky , Rich Felker , "David S. Miller" , cmetcalf@mellanox.com, Max Filippov , Arnd Bergmann , dbueso@suse.de, Wu Fengguang , linux-m68k Message-ID: <20160616191806.Ib0GDFlW1Bzf_dM4C-TmYzWtrDORcGaGjitje7HhQOw@z> Peter Zijlstra writes: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not broken, so nothing to fix. > > Its non obvious code, that's usually plenty reason to change it. You appear to be the only one who has a problem with that documented construct. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."