From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752222AbcABVio (ORCPT ); Sat, 2 Jan 2016 16:38:44 -0500 Received: from canardo.mork.no ([148.122.252.1]:42986 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbcABVil convert rfc822-to-8bit (ORCPT ); Sat, 2 Jan 2016 16:38:41 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: SF Markus Elfring Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() Organization: m References: <566ABCD9.1060404@users.sourceforge.net> <5686AE52.1020008@users.sourceforge.net> <5686AF55.5020801@users.sourceforge.net> Date: Sat, 02 Jan 2016 22:38:30 +0100 In-Reply-To: <5686AF55.5020801@users.sourceforge.net> (SF Markus Elfring's message of "Fri, 1 Jan 2016 17:54:45 +0100") Message-ID: <87vb7bpsq1.fsf@nemi.mork.no> User-Agent: Gnus/5.130013 (Ma Gnus v0.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 1 Jan 2016 17:32:07 +0100 > > Reduce the scope for the local variable "desc" to one branch > of an if statement. This patch is harmless. But is also pointless. You could at least try to explain why this must be changed. I'm not interested in why you think it is better this way - I might agree with that. what I am interested in is the advantage changing the code gives us. Some analysis of the risk and work involved would also be nice. Is this change really worth it? Personally I am convinced that I wasted any time I used writing this, and you wasted any time you used reading it. Sorry. Note: This patch would have been fine if it was a natural part of some *improvement* of the driver, i.e. a bugfix or feaure addition. As a standalone patch I see it as noise. Please stop the noise and start writing something useful. I'm sure you can fix bugs instead. Wouldn't that be more interesting? More challenging? These mindless robotic code refactoring patches are really best left for robots. Bjørn From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() Date: Sat, 02 Jan 2016 22:38:30 +0100 Message-ID: <87vb7bpsq1.fsf@nemi.mork.no> References: <566ABCD9.1060404@users.sourceforge.net> <5686AE52.1020008@users.sourceforge.net> <5686AF55.5020801@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: SF Markus Elfring Return-path: In-Reply-To: <5686AF55.5020801@users.sourceforge.net> (SF Markus Elfring's message of "Fri, 1 Jan 2016 17:54:45 +0100") Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 1 Jan 2016 17:32:07 +0100 > > Reduce the scope for the local variable "desc" to one branch > of an if statement. This patch is harmless. But is also pointless. You could at least try to explain why this must be changed. I'm not interested in why you think it is better this way - I might agree with that. what I am interested in is the advantage changing the code gives us. Some analysis of the risk and work involved would also be nice. I= s this change really worth it? Personally I am convinced that I wasted any time I used writing this, and you wasted any time you used reading it. Sorry. Note: This patch would have been fine if it was a natural part of some *improvement* of the driver, i.e. a bugfix or feaure addition. As a standalone patch I see it as noise. Please stop the noise and start writing something useful. I'm sure you can fix bugs instead. Wouldn't that be more interesting? More challenging? These mindless robotic code refactoring patches are reall= y best left for robots. Bj=C3=B8rn -- To unsubscribe from this list: send the line "unsubscribe kernel-janito= rs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Date: Sat, 02 Jan 2016 21:38:30 +0000 Subject: Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() Message-Id: <87vb7bpsq1.fsf@nemi.mork.no> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5686AE52.1020008@users.sourceforge.net> <5686AF55.5020801@users.sourceforge.net> In-Reply-To: <5686AF55.5020801@users.sourceforge.net> (SF Markus Elfring's message of "Fri, 1 Jan 2016 17:54:45 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 1 Jan 2016 17:32:07 +0100 > > Reduce the scope for the local variable "desc" to one branch > of an if statement. This patch is harmless. But is also pointless. You could at least try to explain why this must be changed. I'm not interested in why you think it is better this way - I might agree with that. what I am interested in is the advantage changing the code gives us. Some analysis of the risk and work involved would also be nice. Is this change really worth it? Personally I am convinced that I wasted any time I used writing this, and you wasted any time you used reading it. Sorry. Note: This patch would have been fine if it was a natural part of some *improvement* of the driver, i.e. a bugfix or feaure addition. As a standalone patch I see it as noise. Please stop the noise and start writing something useful. I'm sure you can fix bugs instead. Wouldn't that be more interesting? More challenging? These mindless robotic code refactoring patches are really best left for robots. Bj=C3=B8rn -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html