From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZKNm7-0003eE-91
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:35:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZKNm4-0007Lp-C7
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:35:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZKNm4-0007Lg-7A
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:35:44 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1435782155-31412-1-git-send-email-armbru@redhat.com>
	<1435782155-31412-48-git-send-email-armbru@redhat.com>
	<55B80E11.6020000@redhat.com>
Date: Wed, 29 Jul 2015 11:35:41 +0200
In-Reply-To: <55B80E11.6020000@redhat.com> (Eric Blake's message of "Tue, 28
	Jul 2015 17:19:45 -0600")
Message-ID: <87vbd3gvbm.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v2 47/47] qapi-introspect: Hide type
	names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Eric Blake <eblake@redhat.com> writes:

> On 07/01/2015 02:22 PM, Markus Armbruster wrote:
>> To eliminate the temptation for clients to look up types by name
>> (which are not ABI), replace all type names by meaningless strings.
>> 
>> Reduces output of query-schema by 9 out of 80KiB.
>
> Among other things, it replaced all instances of 'str' with ':acg', and
> all instances of 'int' with ':adu' (at least for the qapi-schema.json
> files at the point in qemu.git that I tested on); if you were to tweak
> things to NOT rename builtin types (limiting the renaming to just object
> and array types), you'd save even more space and make libvirt's life
> easier by not masking builtin types.  (Yes, the 'meta-type':'builtin'
> entry for 'str' should still be present whether or not we hide the name
> 'str', but knowing the small set of builtin names up front and only
> having to chase objects and arrays seems a bit more efficient)

You're right, hiding builtin types is pointless, they're ABI.