From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387Ab3GOObg (ORCPT ); Mon, 15 Jul 2013 10:31:36 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:53898 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757583Ab3GOObe (ORCPT ); Mon, 15 Jul 2013 10:31:34 -0400 From: "Aneesh Kumar K.V" To: Joonsoo Kim , Andrew Morton Cc: Rik van Riel , Mel Gorman , Michal Hocko , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Joonsoo Kim Subject: Re: [PATCH 5/9] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages() In-Reply-To: <1373881967-16153-6-git-send-email-iamjoonsoo.kim@lge.com> References: <1373881967-16153-1-git-send-email-iamjoonsoo.kim@lge.com> <1373881967-16153-6-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Notmuch/0.15.2+167~g5306b2b (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) Date: Mon, 15 Jul 2013 20:01:24 +0530 Message-ID: <87vc4bj3nn.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13071514-1396-0000-0000-00000342B9C2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joonsoo Kim writes: > If list is empty, list_for_each_entry_safe() doesn't do anything. > So, this check is redundant. Remove it. > > Signed-off-by: Joonsoo Kim Reviewed-by: Aneesh Kumar K.V > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index a838e6b..d4a1695 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1019,10 +1019,8 @@ free: > spin_unlock(&hugetlb_lock); > > /* Free unnecessary surplus pages to the buddy allocator */ > - if (!list_empty(&surplus_list)) { > - list_for_each_entry_safe(page, tmp, &surplus_list, lru) { > - put_page(page); > - } > + list_for_each_entry_safe(page, tmp, &surplus_list, lru) { > + put_page(page); > } You can now remove '{' > spin_lock(&hugetlb_lock); > > -- > 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx139.postini.com [74.125.245.139]) by kanga.kvack.org (Postfix) with SMTP id 31F2C6B0031 for ; Mon, 15 Jul 2013 10:31:34 -0400 (EDT) Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Jul 2013 00:16:10 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 2ABF73578053 for ; Tue, 16 Jul 2013 00:31:29 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6FEGFPi55640290 for ; Tue, 16 Jul 2013 00:16:15 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6FEVRVS010477 for ; Tue, 16 Jul 2013 00:31:28 +1000 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 5/9] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages() In-Reply-To: <1373881967-16153-6-git-send-email-iamjoonsoo.kim@lge.com> References: <1373881967-16153-1-git-send-email-iamjoonsoo.kim@lge.com> <1373881967-16153-6-git-send-email-iamjoonsoo.kim@lge.com> Date: Mon, 15 Jul 2013 20:01:24 +0530 Message-ID: <87vc4bj3nn.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim , Andrew Morton Cc: Rik van Riel , Mel Gorman , Michal Hocko , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Joonsoo Kim writes: > If list is empty, list_for_each_entry_safe() doesn't do anything. > So, this check is redundant. Remove it. > > Signed-off-by: Joonsoo Kim Reviewed-by: Aneesh Kumar K.V > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index a838e6b..d4a1695 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1019,10 +1019,8 @@ free: > spin_unlock(&hugetlb_lock); > > /* Free unnecessary surplus pages to the buddy allocator */ > - if (!list_empty(&surplus_list)) { > - list_for_each_entry_safe(page, tmp, &surplus_list, lru) { > - put_page(page); > - } > + list_for_each_entry_safe(page, tmp, &surplus_list, lru) { > + put_page(page); > } You can now remove '{' > spin_lock(&hugetlb_lock); > > -- > 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org