From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214Ab2DXJzl (ORCPT ); Tue, 24 Apr 2012 05:55:41 -0400 Received: from faui45.informatik.uni-erlangen.de ([131.188.34.45]:60151 "EHLO faui45.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756600Ab2DXJzj convert rfc822-to-8bit (ORCPT ); Tue, 24 Apr 2012 05:55:39 -0400 X-Greylist: delayed 596 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 Apr 2012 05:55:39 EDT From: Reinhard Tartler To: Russell King , Rob Herring , Nicolas Pitre , Arnd Bergmann , Guan Xuetao , Ralf Baechle Cc: vamos-dev@lists.informatik.uni-erlangen.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly Organization: Uni Erlangen, Informatik 4, Lehrstuhl =?utf-8?Q?f=C3=BCr?= Betriebs- und verteilte Systeme X-Url: http://www4.informatik.uni-erlangen.de/~tartler Date: Tue, 24 Apr 2012 11:45:37 +0200 Message-ID: <87vckpsbsu.fsf@faui43f.informatik.uni-erlangen.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, with configration-aware static analysis, we have found a gcc warning that can be fixed easily. Please consider applying the following patch (based on v3.4-rc4). >>From 4fd3be96ed8d35d9825d833623ddd69485ddc5ba Mon Sep 17 00:00:00 2001 From: Reinhard Tartler Date: Tue, 24 Apr 2012 11:35:16 +0200 Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes the following gcc warning: arch/arm/mach-shark/pci.c:42: warning: ‘return’ with no value, in function returning non-void Signed-off-by: Reinhard Tartler --- arch/arm/mach-shark/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-shark/pci.c b/arch/arm/mach-shark/pci.c index 7cb79a0..12fcc47 100644 --- a/arch/arm/mach-shark/pci.c +++ b/arch/arm/mach-shark/pci.c @@ -39,7 +39,7 @@ static struct hw_pci shark_pci __initdata = { static int __init shark_pci_init(void) { if (!machine_is_shark()) - return; + return 1; pcibios_min_io = 0x6000; pcibios_min_mem = 0x50000000; -- 1.7.9.5 -- Reinhard Tartler Department of Computer Science IV Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg http://www4.informatik.uni-erlangen.de/~tartler From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard.Tartler@informatik.uni-erlangen.de (Reinhard Tartler) Date: Tue, 24 Apr 2012 11:45:37 +0200 Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly Message-ID: <87vckpsbsu.fsf@faui43f.informatik.uni-erlangen.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, with configration-aware static analysis, we have found a gcc warning that can be fixed easily. Please consider applying the following patch (based on v3.4-rc4). >>From 4fd3be96ed8d35d9825d833623ddd69485ddc5ba Mon Sep 17 00:00:00 2001 From: Reinhard Tartler Date: Tue, 24 Apr 2012 11:35:16 +0200 Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes the following gcc warning: arch/arm/mach-shark/pci.c:42: warning: ?return? with no value, in function returning non-void Signed-off-by: Reinhard Tartler --- arch/arm/mach-shark/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-shark/pci.c b/arch/arm/mach-shark/pci.c index 7cb79a0..12fcc47 100644 --- a/arch/arm/mach-shark/pci.c +++ b/arch/arm/mach-shark/pci.c @@ -39,7 +39,7 @@ static struct hw_pci shark_pci __initdata = { static int __init shark_pci_init(void) { if (!machine_is_shark()) - return; + return 1; pcibios_min_io = 0x6000; pcibios_min_mem = 0x50000000; -- 1.7.9.5 -- Reinhard Tartler Department of Computer Science IV Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg http://www4.informatik.uni-erlangen.de/~tartler