From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miklos Szeredi Subject: Re: overlayfs patches for ovl_copy_up & ovl_rename Date: Tue, 17 May 2011 20:07:13 +0200 Message-ID: <87vcx9cib2.fsf@tucsk.pomaz.szeredi.hu> References: <201105041659.38427.jordipujolp@gmail.com> <87zkmujzni.fsf@tucsk.pomaz.szeredi.hu> <874o4temys.fsf@tucsk.pomaz.szeredi.hu> <201105171918.03433.jordipujolp@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org To: Jordi Pujol Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:40850 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755891Ab1EQSHB (ORCPT ); Tue, 17 May 2011 14:07:01 -0400 Received: by bwz15 with SMTP id 15so722781bwz.19 for ; Tue, 17 May 2011 11:07:00 -0700 (PDT) In-Reply-To: <201105171918.03433.jordipujolp@gmail.com> (Jordi Pujol's message of "Tue, 17 May 2011 19:18:03 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jordi Pujol writes: > A Dimarts 17 Maig 2011 10:43:39, v=C3=A0reu escriure: >> Miklos Szeredi writes: >> Jordi, what's up with this? >>=20 >> Could you please test the .v8 codebase with this single patch applie= d? > > Hello, > > I did so, but the system has never logged any dump from overlayfs, > this condition does not occur. Which is expected. > But I am so confused about the meaning of this test, I have seen that > other union filesystems will lock dentries for directory operations > and super_blocks for read/write operations, and overlayfs does not. I'm not sure what other filesystems do, but in overlayfs the upper/lowe= r dentry references do not go away until the overlayfs dentry is freed. Jordi, what about the original bug you reported: >>>- a few days ago we talked about an error when repetitive sed instru= ctions=20 >>>were executed, also it happens in other processes, like mantaining l= ist of=20 >>>installed files for actual packages, >>>that is solved in ovl_rename issuing a dget for the old-dentry and p= arent=20 >>>dentries. (This code is inspired on rename.c from unionfs) Is this still happening? Does the debug patch make any difference? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html