From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 195C6ECAAD5 for ; Fri, 2 Sep 2022 14:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F+rmtjzyf0vhduw6yIzl1iY6dcl4nPxcd7CWlkMGeUs=; b=uuoNvUEtYd6H7Q QaKmbC5blyzAmzbmrE4ug3vg4vXUND3FC+5Y9zQGlTxiZxYB9rKjw3558T5NNvj5eQ1+Z3c7I9Bo8 BPT7iCco8UXzEqieYLW5g7++OUJjj52PYGPk/SeyfxM73C6IVOkx7XL/16aKP77uo+pzn4BJYlner rYzHisNbK+1Gs5j5+tG7c0TYD+ynUXdJA8kBGaXiztndNWiwxHbkZRoY9OC7OafxLuKu/b939YYk0 ZejJvggT0Vee48kkgFX7BBuxzQqtwMuewfk5ePYBn5i+6DITipLL+svwbAs5ms2fdBFg+e5KVwuyo YZ3nf3VDp1b+7Ba/CSEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU7T8-005T2P-Lo; Fri, 02 Sep 2022 14:16:26 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU7T5-005Sy5-3H for linux-arm-kernel@lists.infradead.org; Fri, 02 Sep 2022 14:16:24 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8D132240004; Fri, 2 Sep 2022 14:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662128178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jvFVFQ3gZPFCZ+CyZwVWo8EeYLlNEP4xM0MnhWw0ToE=; b=CsizKOruepUqRO6dfvpO3S4Ua7yv1vWk3Lbq7/HmImQdjte/A8y250pyLeJ5VjpXnR8yWM nzsI4PmwJVB3T4QAULUTfDYd/+cO94MEy7N/lhkj1AgxNCfocOWtHMPQbTsEZsZTfdrLiv B2PWt8wG1QsI/tovpc0ruJfjIOesMZFWkIGGwdwQoI5EG5uq/PzHWaBcM9nX2ffbeKJQhg iuiV0WGCTjuPu9AQpMHYgnu9w+jUWCnAzg2cYCgcQX6V0u8kza63Eb3X7zNBQeowarHlXB Kon17A95D7LxVbod3yUJ1NOCbwKRDAwiwwUkHcuDvTav1Vl+OoWdrbFnYZVGkQ== From: Gregory CLEMENT To: Michael Walle , Andrew Lunn , Sebastian Hesselbarth Cc: Rob Herring , Krzysztof Kozlowski , Jason Cooper , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port In-Reply-To: <20220816001026.830127-2-michael@walle.cc> References: <20220816001026.830127-1-michael@walle.cc> <20220816001026.830127-2-michael@walle.cc> Date: Fri, 02 Sep 2022 16:16:15 +0200 Message-ID: <87wnaleua8.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220902_071623_294204_D2B30597 X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Michael Walle writes: > Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet > port. This has always been wrong, i.e. the board code used to set up > both ports, but the driver will play nice and return -ENODEV if the > assiciated PHY is not found. Nevertheless, it is wrong. Remove it. > > Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes") > Signed-off-by: Michael Walle Applied on mvebu/dt Thanks, Gregory > --- > arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi > index 321a40a98ed2..88b70ba1c8fe 100644 > --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi > +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi > @@ -218,22 +218,11 @@ hdd_power: regulator@2 { > &mdio { > status = "okay"; > > - ethphy0: ethernet-phy@0 { > - reg = <0>; > - }; > - > ethphy1: ethernet-phy@8 { > reg = <8>; > }; > }; > > -ð0 { > - status = "okay"; > - ethernet0-port@0 { > - phy-handle = <ðphy0>; > - }; > -}; > - > ð1 { > status = "okay"; > ethernet1-port@0 { > -- > 2.30.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFA6ECAAD5 for ; Fri, 2 Sep 2022 14:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236110AbiIBOw7 (ORCPT ); Fri, 2 Sep 2022 10:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236663AbiIBOwb (ORCPT ); Fri, 2 Sep 2022 10:52:31 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 735541090AF; Fri, 2 Sep 2022 07:16:19 -0700 (PDT) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8D132240004; Fri, 2 Sep 2022 14:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662128178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jvFVFQ3gZPFCZ+CyZwVWo8EeYLlNEP4xM0MnhWw0ToE=; b=CsizKOruepUqRO6dfvpO3S4Ua7yv1vWk3Lbq7/HmImQdjte/A8y250pyLeJ5VjpXnR8yWM nzsI4PmwJVB3T4QAULUTfDYd/+cO94MEy7N/lhkj1AgxNCfocOWtHMPQbTsEZsZTfdrLiv B2PWt8wG1QsI/tovpc0ruJfjIOesMZFWkIGGwdwQoI5EG5uq/PzHWaBcM9nX2ffbeKJQhg iuiV0WGCTjuPu9AQpMHYgnu9w+jUWCnAzg2cYCgcQX6V0u8kza63Eb3X7zNBQeowarHlXB Kon17A95D7LxVbod3yUJ1NOCbwKRDAwiwwUkHcuDvTav1Vl+OoWdrbFnYZVGkQ== From: Gregory CLEMENT To: Michael Walle , Andrew Lunn , Sebastian Hesselbarth Cc: Rob Herring , Krzysztof Kozlowski , Jason Cooper , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port In-Reply-To: <20220816001026.830127-2-michael@walle.cc> References: <20220816001026.830127-1-michael@walle.cc> <20220816001026.830127-2-michael@walle.cc> Date: Fri, 02 Sep 2022 16:16:15 +0200 Message-ID: <87wnaleua8.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Walle writes: > Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet > port. This has always been wrong, i.e. the board code used to set up > both ports, but the driver will play nice and return -ENODEV if the > assiciated PHY is not found. Nevertheless, it is wrong. Remove it. > > Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes") > Signed-off-by: Michael Walle Applied on mvebu/dt Thanks, Gregory > --- > arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi > index 321a40a98ed2..88b70ba1c8fe 100644 > --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi > +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi > @@ -218,22 +218,11 @@ hdd_power: regulator@2 { > &mdio { > status = "okay"; > > - ethphy0: ethernet-phy@0 { > - reg = <0>; > - }; > - > ethphy1: ethernet-phy@8 { > reg = <8>; > }; > }; > > -ð0 { > - status = "okay"; > - ethernet0-port@0 { > - phy-handle = <ðphy0>; > - }; > -}; > - > ð1 { > status = "okay"; > ethernet1-port@0 { > -- > 2.30.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com