From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Maxim Levitsky <mlevitsk@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: warning in kvm_hv_invalidate_tsc_page due to writes to guest memory from VM ioctl context
Date: Wed, 09 Feb 2022 13:44:26 +0100 [thread overview]
Message-ID: <87wni48b11.fsf@redhat.com> (raw)
In-Reply-To: <YgKjDm5OdSOKIdAo@google.com>
Sean Christopherson <seanjc@google.com> writes:
> On Tue, Feb 08, 2022, Vitaly Kuznetsov wrote:
>> Maxim Levitsky <mlevitsk@redhat.com> writes:
>> > and hv-avic only mentions AutoEOI feature.
>>
>> True, this is hidden in "The enlightenment allows to use Hyper-V SynIC
>> with hardware APICv/AVIC enabled". Any suggestions on how to improve
>> this are more than welcome!.
>
> Specifically for the WARN, does this approach makes sense?
>
> https://lore.kernel.org/all/YcTpJ369cRBN4W93@google.com
(Sorry for missing this dicsussion back in December)
It probably does but the patch just introduces
HV_TSC_PAGE_UPDATE_REQUIRED flag and drops kvm_write_guest() completely,
the flag is never reset and nothing ever gets written to guest's
memory. I suppose you've forgotten to commit a hunk :-) This is good
starting poing though, I'll take a look.
--
Vitaly
next prev parent reply other threads:[~2022-02-09 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 14:59 warning in kvm_hv_invalidate_tsc_page due to writes to guest memory from VM ioctl context Maxim Levitsky
2022-02-08 15:15 ` Vitaly Kuznetsov
2022-02-08 15:34 ` Maxim Levitsky
2022-02-08 16:01 ` Vitaly Kuznetsov
2022-02-08 17:06 ` Sean Christopherson
2022-02-09 12:44 ` Vitaly Kuznetsov [this message]
2022-02-09 16:22 ` Sean Christopherson
2022-02-09 17:33 ` Vitaly Kuznetsov
2022-02-10 13:44 ` Vitaly Kuznetsov
2022-02-14 14:22 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wni48b11.fsf@redhat.com \
--to=vkuznets@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.