From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B49E62C81 for ; Wed, 10 Nov 2021 06:59:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1636527569; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: References: In-Reply-To: Subject: Cc: To: From: Sender; bh=S/HSAFn7jaQ8H/1zmCelJn5XhhV3XFMa6E/Om1l9AsQ=; b=SQHwD35rNK7Qsm/rlm0y3GrpJCwxpivJJd+o+9MeMr/n6IK/51yu3X/NCMl6KddxIEy2xBjy oxFo3hSX+zVkOJbc1UvAD0AoHz4WXFQukVtW7TDIOqDyiePjQb9t/sXjDYTy0/36PHAMv6Lx Oy+T+xnJs7crRowkZzoprhzzZi8= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0YzJmNCIsICJyZWdyZXNzaW9uc0BsaXN0cy5saW51eC5kZXYiLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 618b6dd0a06361a25429446b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 10 Nov 2021 06:59:28 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 56584C4360C; Wed, 10 Nov 2021 06:59:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 926FEC4338F; Wed, 10 Nov 2021 06:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 926FEC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: =?utf-8?Q?Stanis=C5=82aw?= Gruszka Cc: Exuvo , Thorsten Leemhuis , Stanislaw Gruszka , "linux-wireless\@vger.kernel.org" , Helmut Schaa , "regressions\@lists.linux.dev" Subject: Re: rt2x00 regression In-Reply-To: (=?utf-8?Q?=22S?= =?utf-8?Q?tanis=C5=82aw?= Gruszka"'s message of "Tue, 09 Nov 2021 18:36:08 +0100") References: <20191203075736.ga701@redhat.com> <87czop5j33.fsf@tynnyri.adurom.net> <6366d9bd-9752-dbc2-8970-442bdc6e8eea@leemhuis.info> <7d353dd2-2ffb-6d5e-9983-f983c8b4f6da@leemhuis.info> <20211109073127.ga109212@wp.pl> <20211109120737.ga120005@wp.pl> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Wed, 10 Nov 2021 08:59:22 +0200 Message-ID: <87wnlgo5rp.fsf@codeaurora.org> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stanis=C5=82aw Gruszka writes: > Dnia 9 listopada 2021 16:22 Exuvo napisa=C5=82(a): > > Just tested it and it passes the rt2x00lib_load_firmware but still error= s on > rt2800usb_set_device_state: > > > > @@ -30,7 +30,8 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_de= v *rt2x00dev, int status) > else > rt2x00dev->num_proto_errs =3D 0; >=20=20=20 > - if (rt2x00dev->num_proto_errs > 3) > + if (rt2x00dev->num_proto_errs > 3 && > + !test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags)) > return true; >=20=20=20 > return false; > > Sorry, I screwed logic in my patch. It should be test_bit() instead of !t= est_bit().=20 > And also we should not count when device did not start. So patch should b= e somewhat different. I'll > send tomorrow hopefully better patch.=20 No HTML, please :) I'll reply so that lists see your email. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes