From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5FEC433EF for ; Fri, 24 Sep 2021 10:48:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2AC261019 for ; Fri, 24 Sep 2021 10:48:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2AC261019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6AAFF6E1B1; Fri, 24 Sep 2021 10:48:57 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F2726E1B1 for ; Fri, 24 Sep 2021 10:48:56 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="309604749" X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="309604749" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 03:48:55 -0700 X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="559239863" Received: from avanhout-mobl.ger.corp.intel.com (HELO localhost) ([10.249.37.153]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 03:48:54 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20210923200109.4459-1-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210923200109.4459-1-ville.syrjala@linux.intel.com> Date: Fri, 24 Sep 2021 13:48:51 +0300 Message-ID: <87wnn69rl8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 23 Sep 2021, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Let's start to reject user modes whose refresh rate is > nowhere near the actual fixed mode refresh rate we're > going to use. ATM we're just flat out lying to the user. I eyeballed through this quickly, mostly seems reasonable, I'll try to do detailed review later. One question though. I think we have bug reports [1][2] about panels that support very high refresh rates, but report a lower refresh rate mode as the preferred mode. It's perhaps a safe default from a power usage standpoint. Does this series make using those modes harder or impossible? BR, Jani. [1] https://gitlab.freedesktop.org/drm/intel/-/issues/2939 [2] https://gitlab.freedesktop.org/drm/intel/-/issues/3969 > > We'll also pimp the connector's mode list validation=20 > a bit. > > Ville Syrj=C3=A4l=C3=A4 (6): > drm/i915: Extract intel_panel_mode_valid() > drm/i915: Use intel_panel_mode_valid() for DSI/LVDS/DVO > drm/i915: Reject modes that don't match fixed_mode vrefresh > drm/i915: Introduce intel_panel_compute_config() > drm/i915: Reject user modes that don't match fixed mode's refresh rate > drm/i915: Drop pointless fixed_mode checks from dsi code > > drivers/gpu/drm/i915/display/icl_dsi.c | 7 ++-- > drivers/gpu/drm/i915/display/intel_dp.c | 13 ++++--- > drivers/gpu/drm/i915/display/intel_dsi.c | 16 ++++----- > drivers/gpu/drm/i915/display/intel_dvo.c | 24 ++++++++----- > drivers/gpu/drm/i915/display/intel_lvds.c | 15 ++++---- > drivers/gpu/drm/i915/display/intel_panel.c | 41 ++++++++++++++++++++-- > drivers/gpu/drm/i915/display/intel_panel.h | 5 +++ > drivers/gpu/drm/i915/display/intel_sdvo.c | 21 ++++++----- > drivers/gpu/drm/i915/display/vlv_dsi.c | 39 +++++++++----------- > 9 files changed, 116 insertions(+), 65 deletions(-) --=20 Jani Nikula, Intel Open Source Graphics Center