From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20210722110903.8769-1-alex.bennee@linaro.org> <87czr34v66.fsf@redhat.com> <87y29kgw3i.fsf@linaro.org> <87czqw1cf2.fsf@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [virtio-comment] [PATCH] virtio-rpmb: fix the description for multi-block reads Date: Tue, 03 Aug 2021 16:38:39 +0100 In-reply-to: <87czqw1cf2.fsf@redhat.com> Message-ID: <87wnp2fshe.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: Cornelia Huck Cc: virtio-comment@lists.oasis-open.org, maxim.uvarov@linaro.org, joakim.bech@linaro.org, ulf.hansson@linaro.org, ilias.apalodimas@linaro.org, arnd@linaro.org, ruchika.gupta@linaro.org, tomas.winkler@intel.com, yang.huang@intel.com, bing.zhu@intel.com, Matti.Moell@opensynergy.com, hmo@opensynergy.com List-ID: Cornelia Huck writes: > On Mon, Aug 02 2021, Alex Benn=C3=A9e wrote: > >> Cornelia Huck writes: >> >>> On Thu, Jul 22 2021, Alex Benn=C3=A9e wrote: >>> >>>> Previously the text said we fail if block count is set to 1 despite >>>> language elsewhere in the text referring to: >>>> >>>> "For RPMB read request, one virtio buffer including request command >>>> and the subsequent [block_count] virtio buffers for response data >>>> are placed in the queue." >>>> >>>> and the existence of both max_wr_cnt and max_rd_cnt configuration >>>> variables certainly implying devices should be able to handle >>>> multi-block reads just like writes. >>>> >>>> Fix the description as well as format the steps as an enumerated list >>>> to match the style of the previous section describing write handling. >>>> >>>> Reported-by: Ruchika Gupta >>>> Signed-off-by: Alex Benn=C3=A9e >>>> --- >>>> virtio-rpmb.tex | 24 +++++++++++++----------- >>>> 1 file changed, 13 insertions(+), 11 deletions(-) >>> >>> Do you want to request a vote for this? >> >> Sure - I think it's a clarification rather than a "new" feature but >> whatever is needed to get it merged ;-) > > Yes, I think it is slightly over the line of things I would merge as an > editorial update, so please open a github issue. Done: https://github.com/oasis-tcs/virtio-spec/issues/113 --=20 Alex Benn=C3=A9e