From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B5496E882 for ; Wed, 23 Jun 2021 03:18:11 +0000 (UTC) Date: Tue, 22 Jun 2021 20:18:09 -0700 Message-ID: <87wnqljmku.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210617191516.577394-26-jason@jlekstrand.net> References: <20210617191256.577244-1-jason@jlekstrand.net> <20210617191516.577394-26-jason@jlekstrand.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 75/79] tests/i915/gem_ctx_param: Add tests for recently removed params List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, 17 Jun 2021 12:15:12 -0700, Jason Ekstrand wrote: > Please add SOB. > @@ -406,6 +435,21 @@ igt_main > igt_assert_eq(__gem_context_set_param(fd, &arg), -EINVAL); > } > > + igt_subtest("invalid-set-ringsize") > + test_set_invalid_param(fd, I915_CONTEXT_PARAM_RINGSIZE, 8192); > + > + igt_subtest("invalid-get-ringsize") > + test_get_invalid_param(fd, I915_CONTEXT_PARAM_RINGSIZE); > + > + igt_subtest("invalid-set-no-zeromap") > + test_set_invalid_param(fd, I915_CONTEXT_PARAM_NO_ZEROMAP, 1); > + > + igt_subtest("invalid-get-no-zeromap") > + test_get_invalid_param(fd, I915_CONTEXT_PARAM_NO_ZEROMAP); > + > + igt_subtest("invalid-get-engines") > + test_get_invalid_param(fd, I915_CONTEXT_PARAM_ENGINES); Overall I'd have preferred that if we can set engines we should also be able to get engines and a lot of these changes would have been avoided if we had just been able to do that. The savings for removing get_engines are also minimal. However since a decision somewhere seems to have been made to remove get_engines this is: Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev