From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02459C48BE8 for ; Tue, 15 Jun 2021 14:06:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3CC2613D9 for ; Tue, 15 Jun 2021 14:06:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbhFOOI0 (ORCPT ); Tue, 15 Jun 2021 10:08:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37202 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhFOOIW (ORCPT ); Tue, 15 Jun 2021 10:08:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623765977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JE2dgBTMtQppLdKX6wEsCIQ28gJrM1OUnMU/8ZeALkY=; b=TXbzgJRAzc5kNdJHWqJjRAFiJtk4s5aI9W3dNkZ9e0K9lOk3xnB94CCqk1GmYQzBeXE9pS Q3U5/OmS6l06DQQQCcf1ZUdVec1FSK4i9/B3P6hSQeTk2ZjUWKMUJLWiDVxHwkjsrxdtvf XW7jDHYXKBbkxhaq4Xpc7TPy5pmpZV0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-cFV8b5FIOC-OMnA7y9F_4w-1; Tue, 15 Jun 2021 10:06:15 -0400 X-MC-Unique: cFV8b5FIOC-OMnA7y9F_4w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71108801B19; Tue, 15 Jun 2021 14:06:13 +0000 (UTC) Received: from localhost (ovpn-113-156.ams2.redhat.com [10.36.113.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9C1B5D6AD; Tue, 15 Jun 2021 14:06:12 +0000 (UTC) From: Cornelia Huck To: Christoph Hellwig , Greg Kroah-Hartman , Jason Gunthorpe , Alex Williamson , Kirti Wankhede Cc: David Airlie , Tony Krowiak , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , dri-devel@lists.freedesktop.org, Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Halil Pasic , "Rafael J. Wysocki" , Rodrigo Vivi Subject: Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind In-Reply-To: <20210615133519.754763-8-hch@lst.de> Organization: Red Hat GmbH References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-8-hch@lst.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 15 Jun 2021 16:06:11 +0200 Message-ID: <87wnqvw7cc.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Tue, Jun 15 2021, Christoph Hellwig wrote: > From: Jason Gunthorpe > > This allows a mdev driver to opt out of using vfio_mdev.c, instead the > driver will provide a 'struct mdev_driver' and register directly with the > driver core. > > Much of mdev_parent_ops becomes unused in this mode: > - create()/remove() are done via the mdev_driver probe()/remove() > - mdev_attr_groups becomes mdev_driver driver.dev_groups > - Wrapper function callbacks are replaced with the same ones from > struct vfio_device_ops > > Signed-off-by: Jason Gunthorpe > Signed-off-by: Christoph Hellwig > --- > drivers/vfio/mdev/mdev_core.c | 30 ++++++++++++++++++++++-------- > drivers/vfio/mdev/mdev_driver.c | 10 ++++++++++ > include/linux/mdev.h | 2 ++ > 3 files changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DED8C48BE5 for ; Tue, 15 Jun 2021 14:06:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D99BF61459 for ; Tue, 15 Jun 2021 14:06:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D99BF61459 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F101F6E063; Tue, 15 Jun 2021 14:06:21 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 943A389363 for ; Tue, 15 Jun 2021 14:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623765979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JE2dgBTMtQppLdKX6wEsCIQ28gJrM1OUnMU/8ZeALkY=; b=J//74bpXDiPzKTESJRwiJjEZax/sYHr9TwUc2vBRiyn7AnzZTdjtoxUbsmuQ4Z5yqBgWxc N8p9LwVFXKnQCg9SeOacrhrY3FjbflXGfsErbLWfdrqLT+uDmP+Lphz+dvwH3sj5JFRk2D DDsg7QRhZzouqycYPBkooGDO32/fPbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-cFV8b5FIOC-OMnA7y9F_4w-1; Tue, 15 Jun 2021 10:06:15 -0400 X-MC-Unique: cFV8b5FIOC-OMnA7y9F_4w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71108801B19; Tue, 15 Jun 2021 14:06:13 +0000 (UTC) Received: from localhost (ovpn-113-156.ams2.redhat.com [10.36.113.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9C1B5D6AD; Tue, 15 Jun 2021 14:06:12 +0000 (UTC) From: Cornelia Huck To: Christoph Hellwig , Greg Kroah-Hartman , Jason Gunthorpe , Alex Williamson , Kirti Wankhede Subject: Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind In-Reply-To: <20210615133519.754763-8-hch@lst.de> Organization: Red Hat GmbH References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-8-hch@lst.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 15 Jun 2021 16:06:11 +0200 Message-ID: <87wnqvw7cc.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Krowiak , Jason Herne , kvm@vger.kernel.org, Vasily Gorbik , Jonathan Corbet , David Airlie , linux-s390@vger.kernel.org, Heiko Carstens , linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, Halil Pasic , Christian Borntraeger , Rodrigo Vivi , "Rafael J. Wysocki" , intel-gfx@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 15 2021, Christoph Hellwig wrote: > From: Jason Gunthorpe > > This allows a mdev driver to opt out of using vfio_mdev.c, instead the > driver will provide a 'struct mdev_driver' and register directly with the > driver core. > > Much of mdev_parent_ops becomes unused in this mode: > - create()/remove() are done via the mdev_driver probe()/remove() > - mdev_attr_groups becomes mdev_driver driver.dev_groups > - Wrapper function callbacks are replaced with the same ones from > struct vfio_device_ops > > Signed-off-by: Jason Gunthorpe > Signed-off-by: Christoph Hellwig > --- > drivers/vfio/mdev/mdev_core.c | 30 ++++++++++++++++++++++-------- > drivers/vfio/mdev/mdev_driver.c | 10 ++++++++++ > include/linux/mdev.h | 2 ++ > 3 files changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FCD2C48BDF for ; Tue, 15 Jun 2021 14:06:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D33E6613D9 for ; Tue, 15 Jun 2021 14:06:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D33E6613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E7EA89363; Tue, 15 Jun 2021 14:06:21 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC4EF89BF1 for ; Tue, 15 Jun 2021 14:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623765979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JE2dgBTMtQppLdKX6wEsCIQ28gJrM1OUnMU/8ZeALkY=; b=J//74bpXDiPzKTESJRwiJjEZax/sYHr9TwUc2vBRiyn7AnzZTdjtoxUbsmuQ4Z5yqBgWxc N8p9LwVFXKnQCg9SeOacrhrY3FjbflXGfsErbLWfdrqLT+uDmP+Lphz+dvwH3sj5JFRk2D DDsg7QRhZzouqycYPBkooGDO32/fPbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-cFV8b5FIOC-OMnA7y9F_4w-1; Tue, 15 Jun 2021 10:06:15 -0400 X-MC-Unique: cFV8b5FIOC-OMnA7y9F_4w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71108801B19; Tue, 15 Jun 2021 14:06:13 +0000 (UTC) Received: from localhost (ovpn-113-156.ams2.redhat.com [10.36.113.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9C1B5D6AD; Tue, 15 Jun 2021 14:06:12 +0000 (UTC) From: Cornelia Huck To: Christoph Hellwig , Greg Kroah-Hartman , Jason Gunthorpe , Alex Williamson , Kirti Wankhede In-Reply-To: <20210615133519.754763-8-hch@lst.de> Organization: Red Hat GmbH References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-8-hch@lst.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 15 Jun 2021 16:06:11 +0200 Message-ID: <87wnqvw7cc.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Subject: Re: [Intel-gfx] [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Krowiak , Jason Herne , kvm@vger.kernel.org, Vasily Gorbik , Jonathan Corbet , David Airlie , linux-s390@vger.kernel.org, Heiko Carstens , linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, Halil Pasic , Christian Borntraeger , "Rafael J. Wysocki" , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jun 15 2021, Christoph Hellwig wrote: > From: Jason Gunthorpe > > This allows a mdev driver to opt out of using vfio_mdev.c, instead the > driver will provide a 'struct mdev_driver' and register directly with the > driver core. > > Much of mdev_parent_ops becomes unused in this mode: > - create()/remove() are done via the mdev_driver probe()/remove() > - mdev_attr_groups becomes mdev_driver driver.dev_groups > - Wrapper function callbacks are replaced with the same ones from > struct vfio_device_ops > > Signed-off-by: Jason Gunthorpe > Signed-off-by: Christoph Hellwig > --- > drivers/vfio/mdev/mdev_core.c | 30 ++++++++++++++++++++++-------- > drivers/vfio/mdev/mdev_driver.c | 10 ++++++++++ > include/linux/mdev.h | 2 ++ > 3 files changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Cornelia Huck _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx