From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F36DC433E0 for ; Fri, 15 May 2020 12:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D3D220709 for ; Fri, 15 May 2020 12:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="vGGnjcDh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbgEOM2i (ORCPT ); Fri, 15 May 2020 08:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbgEOM2f (ORCPT ); Fri, 15 May 2020 08:28:35 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E54C061A0C for ; Fri, 15 May 2020 05:28:33 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s8so3304459wrt.9 for ; Fri, 15 May 2020 05:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=8CBmhx9ui3qJxYivj5qzMWxfms8vf7DMdx7vVNSjA8c=; b=vGGnjcDhIBopZLFVLn2T3uR4fy/h1Jea54IFYPCJ4/m/2BQ7vKoRoVRyf+9bTtKuS8 /OKsdJoy2rFrug9YW2g/pXktJUu3g+HWFPnf5mdLSm+eGo0y6qB7jQI+oDya51Umb5Qo SN3ZEFgFbvACJhXyWd0CHVSEdQ17bb87p+q2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=8CBmhx9ui3qJxYivj5qzMWxfms8vf7DMdx7vVNSjA8c=; b=rr625DNedKlYTYmsi8NXcLHGPP0TMKbmJ0v/d7ElPDUHVtaqBw2sQ6aRRD1qDtKY1x PKBV9iIaNOhreTnZZF0+V/9u4UuX/tFR62mJRGjfg1P86q2qotTvVWSIcyuodPav5lbC AmdKKunLaY8YHYiTHaQNtlBOv7mhVQVTs4QUxHANfCk8RDs17QsW1NFB4nUqoi14UZxc VJBfe7fIe6w8NjP8y3U65EK6+8JLCIMSjLnInHyNhZvus58lNUOolN7366WjzerSrRt5 41dtrs0Oqb47Pj17etT7ujE3xnBbLqUt0sxopRnoWZ8mtnLfhCDak92OdconltO0I1hj AgpA== X-Gm-Message-State: AOAM533CLBSVDMpm6xm3BpEuUefd7Fe6yLverv0sohxV3mbEagqoQo7W ORSb9KRsFTKiqGgbgDrUAzsveQ== X-Google-Smtp-Source: ABdhPJzuJO3h9wm9P+HDKn4bQyUeRVRQ2oDHXcFbX7IhBImY1lx/94mnSy7aM8awmKA1Hpau8zRqXA== X-Received: by 2002:adf:decb:: with SMTP id i11mr4341029wrn.172.1589545712448; Fri, 15 May 2020 05:28:32 -0700 (PDT) Received: from cloudflare.com ([2a02:a310:c262:aa00:b35e:8938:2c2a:ba8b]) by smtp.gmail.com with ESMTPSA id b12sm3663696wmj.0.2020.05.15.05.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 05:28:31 -0700 (PDT) References: <20200511185218.1422406-1-jakub@cloudflare.com> <20200511185218.1422406-6-jakub@cloudflare.com> <20200511204445.i7sessmtszox36xd@ast-mbp> User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Alexei Starovoitov Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, dccp@vger.kernel.org, kernel-team@cloudflare.com, Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Gerrit Renker , Jakub Kicinski , Andrii Nakryiko , Martin KaFai Lau , Marek Majkowski , Lorenz Bauer Subject: Re: [PATCH bpf-next v2 05/17] inet: Run SK_LOOKUP BPF program on socket lookup In-reply-to: <20200511204445.i7sessmtszox36xd@ast-mbp> Date: Fri, 15 May 2020 14:28:30 +0200 Message-ID: <87wo5d2xht.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, May 11, 2020 at 10:44 PM CEST, Alexei Starovoitov wrote: > On Mon, May 11, 2020 at 08:52:06PM +0200, Jakub Sitnicki wrote: >> Run a BPF program before looking up a listening socket on the receive path. >> Program selects a listening socket to yield as result of socket lookup by >> calling bpf_sk_assign() helper and returning BPF_REDIRECT code. >> >> Alternatively, program can also fail the lookup by returning with BPF_DROP, >> or let the lookup continue as usual with BPF_OK on return. >> >> This lets the user match packets with listening sockets freely at the last >> possible point on the receive path, where we know that packets are destined >> for local delivery after undergoing policing, filtering, and routing. >> >> With BPF code selecting the socket, directing packets destined to an IP >> range or to a port range to a single socket becomes possible. >> >> Suggested-by: Marek Majkowski >> Reviewed-by: Lorenz Bauer >> Signed-off-by: Jakub Sitnicki >> --- [...] > Also please switch to bpf_link way of attaching. All system wide attachments > should be visible and easily debuggable via 'bpftool link show'. > Currently we're converting tc and xdp hooks to bpf_link. This new hook > should have it from the beginning. Just to clarify, I understood that bpf(BPF_PROG_ATTACH/DETACH) doesn't have to be supported for new hooks. Please correct me if I misunderstood. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Sitnicki Date: Fri, 15 May 2020 12:28:30 +0000 Subject: Re: [PATCH bpf-next v2 05/17] inet: Run SK_LOOKUP BPF program on socket lookup Message-Id: <87wo5d2xht.fsf@cloudflare.com> List-Id: References: <20200511185218.1422406-6-jakub@cloudflare.com> In-Reply-To: <20200511185218.1422406-6-jakub@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org On Mon, May 11, 2020 at 10:44 PM CEST, Alexei Starovoitov wrote: > On Mon, May 11, 2020 at 08:52:06PM +0200, Jakub Sitnicki wrote: >> Run a BPF program before looking up a listening socket on the receive path. >> Program selects a listening socket to yield as result of socket lookup by >> calling bpf_sk_assign() helper and returning BPF_REDIRECT code. >> >> Alternatively, program can also fail the lookup by returning with BPF_DROP, >> or let the lookup continue as usual with BPF_OK on return. >> >> This lets the user match packets with listening sockets freely at the last >> possible point on the receive path, where we know that packets are destined >> for local delivery after undergoing policing, filtering, and routing. >> >> With BPF code selecting the socket, directing packets destined to an IP >> range or to a port range to a single socket becomes possible. >> >> Suggested-by: Marek Majkowski >> Reviewed-by: Lorenz Bauer >> Signed-off-by: Jakub Sitnicki >> --- [...] > Also please switch to bpf_link way of attaching. All system wide attachments > should be visible and easily debuggable via 'bpftool link show'. > Currently we're converting tc and xdp hooks to bpf_link. This new hook > should have it from the beginning. Just to clarify, I understood that bpf(BPF_PROG_ATTACH/DETACH) doesn't have to be supported for new hooks. Please correct me if I misunderstood.