From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 1/3] qom/object: Move Object typedef to 'qemu/typedefs.h'
Date: Fri, 15 May 2020 08:07:25 +0200 [thread overview]
Message-ID: <87wo5drasi.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200504115656.6045-2-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 4 May 2020 13:56:54 +0200")
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> We use the Object type all over the place.
> Forward declare it in "qemu/typedefs.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/qemu/typedefs.h | 1 +
> include/qom/object.h | 2 --
> include/qom/qom-qobject.h | 2 --
> include/sysemu/sysemu.h | 1 -
> 4 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index 375770a80f..b03ec9f40a 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -75,6 +75,7 @@ typedef struct NetFilterState NetFilterState;
> typedef struct NICInfo NICInfo;
> typedef struct NodeInfo NodeInfo;
> typedef struct NumaNodeMem NumaNodeMem;
> +typedef struct Object Object;
> typedef struct ObjectClass ObjectClass;
> typedef struct PCIBridge PCIBridge;
> typedef struct PCIBus PCIBus;
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 784c97c0e1..1edc12e64c 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -20,8 +20,6 @@
> struct TypeImpl;
> typedef struct TypeImpl *Type;
>
> -typedef struct Object Object;
> -
> typedef struct TypeInfo TypeInfo;
>
> typedef struct InterfaceClass InterfaceClass;
> diff --git a/include/qom/qom-qobject.h b/include/qom/qom-qobject.h
> index 77cd717e3f..82136e6e80 100644
> --- a/include/qom/qom-qobject.h
> +++ b/include/qom/qom-qobject.h
> @@ -13,8 +13,6 @@
> #ifndef QEMU_QOM_QOBJECT_H
> #define QEMU_QOM_QOBJECT_H
>
> -#include "qom/object.h"
> -
> /*
> * object_property_get_qobject:
> * @obj: the object
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index ef81302e1a..ca4458e451 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -5,7 +5,6 @@
> #include "qemu/timer.h"
> #include "qemu/notify.h"
> #include "qemu/uuid.h"
> -#include "qom/object.h"
>
> /* vl.c */
How did you identify the inclusions to drop?
next prev parent reply other threads:[~2020-05-15 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 11:56 [PATCH v2 0/3] qom: Few trivial patches Philippe Mathieu-Daudé
2020-05-04 11:56 ` [PATCH v2 1/3] qom/object: Move Object typedef to 'qemu/typedefs.h' Philippe Mathieu-Daudé
2020-05-15 6:07 ` Markus Armbruster [this message]
2020-05-15 7:00 ` Philippe Mathieu-Daudé
2020-05-18 4:52 ` Markus Armbruster
2020-05-21 14:13 ` Paolo Bonzini
2020-05-04 11:56 ` [PATCH v2 2/3] io/task: Move 'qom/object.h' header to source Philippe Mathieu-Daudé
2020-05-04 11:56 ` [PATCH v2 3/3] qom/object: Make reparenting error more verbose Philippe Mathieu-Daudé
2020-05-12 7:02 ` [PATCH v2 0/3] qom: Few trivial patches Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo5drasi.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.