From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF36C3A59E for ; Wed, 21 Aug 2019 14:34:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20CE21655 for ; Wed, 21 Aug 2019 14:34:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20CE21655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0RhD-0004pk-TM for qemu-devel@archiver.kernel.org; Wed, 21 Aug 2019 10:34:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36974) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Rg9-0003lb-P4 for qemu-devel@nongnu.org; Wed, 21 Aug 2019 10:33:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0Rg7-0005MS-NJ for qemu-devel@nongnu.org; Wed, 21 Aug 2019 10:33:37 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:36235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i0Rg7-0005KE-01 for qemu-devel@nongnu.org; Wed, 21 Aug 2019 10:33:35 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id E54675BCA8; Wed, 21 Aug 2019 23:33:31 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ae227063.dynamic.ppp.asahi-net.or.jp [14.3.227.63]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 3FEEB240085; Wed, 21 Aug 2019 23:33:31 +0900 (JST) Date: Wed, 21 Aug 2019 23:33:30 +0900 Message-ID: <87wof6k2px.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= In-Reply-To: <4ccb8b92-8474-6238-3586-f7c68dc1670f@redhat.com> References: <20190817073628.94473-1-ysato@users.sourceforge.jp> <20190817073628.94473-23-ysato@users.sourceforge.jp> <4ccb8b92-8474-6238-3586-f7c68dc1670f@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 Subject: Re: [Qemu-devel] [PATCH v23 22/22] target/rx: remove unused functions. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, richard.henderson@linaro.org, qemu-devel@nongnu.org, imammedo@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 21 Aug 2019 19:23:09 +0900, Philippe Mathieu-Daud=E9 wrote: >=20 > On 8/17/19 9:36 AM, Yoshinori Sato wrote: > > Signed-off-by: Yoshinori Sato > > --- > > target/rx/monitor.c | 38 -------------------------------------- > > target/rx/Makefile.objs | 1 - > > 2 files changed, 39 deletions(-) > > delete mode 100644 target/rx/monitor.c > >=20 > > diff --git a/target/rx/monitor.c b/target/rx/monitor.c > > deleted file mode 100644 > > index 5d7a1e58b5..0000000000 > > --- a/target/rx/monitor.c > > +++ /dev/null >=20 > Why not squash it in your patch #06 "target/rx: CPU definition"? >=20 > If you are OK with this suggestion and there is no more comment on this > series, the maintainer willing to take your series can probably do that > for you (no need to repost!). Oh. I forgot this changes. There are currently no issues with this series. > > @@ -1,38 +0,0 @@ > > -/* > > - * QEMU monitor > > - * > > - * Copyright (c) 2003-2004 Fabrice Bellard > > - * > > - * Permission is hereby granted, free of charge, to any person obtaini= ng a copy > > - * of this software and associated documentation files (the "Software"= ), to deal > > - * in the Software without restriction, including without limitation t= he rights > > - * to use, copy, modify, merge, publish, distribute, sublicense, and/o= r sell > > - * copies of the Software, and to permit persons to whom the Software = is > > - * furnished to do so, subject to the following conditions: > > - * > > - * The above copyright notice and this permission notice shall be incl= uded in > > - * all copies or substantial portions of the Software. > > - * > > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXP= RESS OR > > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABI= LITY, > > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT S= HALL > > - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES O= R OTHER > > - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARI= SING FROM, > > - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALI= NGS IN > > - * THE SOFTWARE. > > - */ > > -#include "qemu/osdep.h" > > -#include "cpu.h" > > -#include "monitor/monitor.h" > > -#include "monitor/hmp-target.h" > > -#include "hmp.h" > > - > > -void hmp_info_tlb(Monitor *mon, const QDict *qdict) > > -{ > > - CPUArchState *env =3D mon_get_cpu_env(); > > - > > - if (!env) { > > - monitor_printf(mon, "No CPU available\n"); > > - return; > > - } > > -} > > diff --git a/target/rx/Makefile.objs b/target/rx/Makefile.objs > > index aa6f2d2d6c..a0018d5bc5 100644 > > --- a/target/rx/Makefile.objs > > +++ b/target/rx/Makefile.objs > > @@ -1,5 +1,4 @@ > > obj-y +=3D translate.o op_helper.o helper.o cpu.o gdbstub.o disas.o > > -obj-$(CONFIG_SOFTMMU) +=3D monitor.o > > =20 > > DECODETREE =3D $(SRC_PATH)/scripts/decodetree.py > > =20 > >=20 --=20 Yosinori Sato