All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com,
	peter.maydell@linaro.org, war2jordan@live.com,
	crosthwaite.peter@gmail.com, boost.lists@gmail.com,
	quintela@redhat.com, ciro.santilli@gmail.com,
	jasowang@redhat.com, mst@redhat.com, zuban32s@gmail.com,
	armbru@redhat.com, maria.klimushenkova@ispras.ru,
	dovgaluk@ispras.ru, kraxel@redhat.com,
	thomas.dullien@googlemail.com, pbonzini@redhat.com,
	mreitz@redhat.com, dgilbert@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer
Date: Thu, 26 Jul 2018 18:20:45 +0100	[thread overview]
Message-ID: <87wothsyky.fsf@linaro.org> (raw)
In-Reply-To: <87zhyerotn.fsf@linaro.org>


Alex Bennée <alex.bennee@linaro.org> writes:

> Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru> writes:
>
>> Replay is capable of recording normal BH events, but sometimes
>> there are single use callbacks scheduled with aio_bh_schedule_oneshot
>> function. This patch enables recording and replaying such callbacks.
>> Block layer uses these events for calling the completion function.
>> Replaying these calls makes the execution deterministic.
>>
>> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>
> I'm not sure what about this commit causes the compile breakage I'm
> seeing:
>
>   LINK    aarch64-linux-user/qemu-aarch64
> ../libqemuutil.a(cpu-get-icount.o):(.bss+0x0): multiple definition of `use_icount'
> exec.o:(.bss+0x58): first defined here
> collect2: error: ld returned 1 exit status
> Makefile:199: recipe for target 'qemu-aarch64' failed
> make[1]: *** [qemu-aarch64] Error 1
> Makefile:481: recipe for target 'subdir-aarch64-linux-user' failed
> make: *** [subdir-aarch64-linux-user] Error 2
>
> It only occurs on a make clean && make -j on that commit though. It's
> hidden if you do incremental builds.

And it seems to be the same failure across all the cross builds:

  https://app.shippable.com/github/stsquad/qemu/runs/538/summary/console

--
Alex Bennée

  reply	other threads:[~2018-07-26 17:20 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 12:13 [Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 01/24] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 02/24] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 03/24] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 04/24] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 05/24] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 06/24] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 07/24] migration: " Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 08/24] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2018-07-25 14:56   ` Dr. David Alan Gilbert
2018-07-31  6:54     ` Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 09/24] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 10/24] replay: implement replay-seek command to proceed to the desired step Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 11/24] replay: flush events when exiting Pavel Dovgalyuk
2018-07-25 12:15 ` [Qemu-devel] [PATCH v5 12/24] timer: remove replay clock probe in deadline calculation Pavel Dovgalyuk
2018-07-25 12:15 ` [Qemu-devel] [PATCH v5 13/24] replay: refine replay-time module Pavel Dovgalyuk
2018-07-25 12:15 ` [Qemu-devel] [PATCH v5 14/24] translator: fix breakpoint processing Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 15/24] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 16/24] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 17/24] gdbstub: add reverse continue " Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 18/24] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 19/24] replay: allow loading any snapshots before recording Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 20/24] ps2: prevent changing irq state on save and load Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 21/24] replay: wake up vCPU when replaying Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation Pavel Dovgalyuk
2018-07-25 12:29   ` Paolo Bonzini
2018-07-25 12:17 ` [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2018-07-26 15:36   ` Alex Bennée
2018-07-26 17:20     ` Alex Bennée [this message]
2018-07-27  4:52     ` Pavel Dovgalyuk
2018-07-27 16:44       ` Alex Bennée
2018-08-02  5:50         ` Pavel Dovgalyuk
2018-07-26 17:17   ` Alex Bennée
2018-07-31  7:00     ` Pavel Dovgalyuk
2018-08-01 16:54     ` Paolo Bonzini
2018-07-25 12:17 ` [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers Pavel Dovgalyuk
2018-07-25 13:44   ` Samuel Thibault
2018-07-26  7:08     ` Pavel Dovgalyuk
2018-07-26  7:35       ` Samuel Thibault
2018-07-26  7:37         ` Pavel Dovgalyuk
2018-07-26  7:40           ` Samuel Thibault
2018-07-26  8:07       ` Samuel Thibault
2018-07-26  8:37         ` Pavel Dovgalyuk
2018-07-26  9:15           ` Samuel Thibault
2018-07-31  6:58             ` Pavel Dovgalyuk
2018-08-01 19:22               ` Samuel Thibault
2018-07-25 14:15 ` [Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging no-reply
2018-08-07 23:13 ` Ciro Santilli
2018-09-12  8:14   ` dovgaluk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wothsyky.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=armbru@redhat.com \
    --cc=boost.lists@gmail.com \
    --cc=ciro.santilli@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=thomas.dullien@googlemail.com \
    --cc=war2jordan@live.com \
    --cc=zuban32s@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.