From: Robert.Larice@t-online.de (Robert Larice)
To: cocci@systeme.lip6.fr
Subject: [Cocci] please help me with a failing match
Date: Sat, 10 Feb 2018 16:04:15 +0100 [thread overview]
Message-ID: <87wozkkhsg.fsf@t-online.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1802101422060.3317@hadrien> (Julia Lawall's message of "Sat, 10 Feb 2018 14:23:17 +0100 (CET)")
Julia Lawall <julia.lawall@lip6.fr> writes:
> On Sat, 10 Feb 2018, Robert Larice wrote:
>
>> Dear People,
>>
>> I'm completely new here.
>>
>> Attached is a small piece of .c and a .cocci file.
>> There is a "return 41;" in both files, commented out.
>> If I uncomment this "return 41;" in both files then
>> spatch will not match the pieces any more.
>>
>> Could you please help me to undertand and circumvent this issue ?
>
> I have not noticed this problem before, but I suspect that it is due to
> the fact that Coccinelle is matching the control-flow path and not the
> abstract syntax tree. In a control-flow graph, nothing follows a return.
>
> julia
Thank You,
I tried to sneak around the problem with a second "rule" which
translates "return 42" to "auxiliary(42)".
My intention was to first change the source in such a way
that the "control-flow" graph does not end at the "return",
and then hope that the second (accordingly modified) rule would
match.
This didn't work, I assume I would have to express the idea of
first applying the first rule
then to rebuild the control-flow graph
then try the second rule.
(and finally undo the changes of the first rule in a third rule)
I can not force "rebuild" without invoking spatch myself a second time.
---
I'm a bit of a maintainer for the "ngspice" project, which has a vast
amount of very old files, and lots of semi duplicated stuff often crying
for a thourough hair wash,
stumbled over this intresting tool, and am tying it for a certain
rewrite I'm currently busy with.
next prev parent reply other threads:[~2018-02-10 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 12:12 [Cocci] please help me with a failing match Robert Larice
2018-02-10 13:23 ` Julia Lawall
2018-02-10 15:04 ` Robert Larice [this message]
2018-02-10 15:15 ` Julia Lawall
2018-02-17 9:06 ` Robert Larice
2018-02-17 13:22 ` Julia Lawall
2018-02-17 14:05 ` Robert Larice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wozkkhsg.fsf@t-online.de \
--to=robert.larice@t-online.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.