From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 122/187] ASoC: twl4030: replace codec to component Date: Fri, 19 Jan 2018 00:46:18 +0000 Message-ID: <87wp0eekxd.wl%kuninori.morimoto.gx@renesas.com> References: <87bmhzevk9.wl%kuninori.morimoto.gx@renesas.com> <87fu7b7sz4.wl%kuninori.morimoto.gx@renesas.com> <5a4a4358-75c3-886b-bb6d-d9cbfecfca4b@ti.com> <87tvvkkp2q.wl%kuninori.morimoto.gx@renesas.com> <20180118170944.GC6747@sirena.org.uk> <87607yg18s.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from relmlie1.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa0.perex.cz (Postfix) with ESMTP id D3F24267886 for ; Fri, 19 Jan 2018 01:46:26 +0100 (CET) In-Reply-To: <87607yg18s.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Peter Ujfalusi , Linux-ALSA , Simon List-Id: alsa-devel@alsa-project.org Hi Mark, again > > > > The pmdown_time was 5000 by default (see soc-core.c). > > > > Ah, in snd_soc_component_driver the pmdown_timme is _not_ pmdown_time, > > > > but use_pmdown_time boolean... > > > > > Ahh, naming... hmm.. Yes, indeed. > > > Mark, I know you still not yet accepting these. > > > We can have 2nd chance to name it ? > > > > Yes, no problem with changes. This feels like we might want to add a > > pmdown_time in the component as well. > > Thanks. > I will change name current .pmdown_time to .use_pmdown_time. > Adding new pmdown_time on component is different patch. Because it is very big patch-set. To avoid patch-bomb on ML, I want to wait other opinion, and will rework/repost it around -rc1 timing. Best regards --- Kuninori Morimoto