From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754759AbdLFEvu (ORCPT ); Tue, 5 Dec 2017 23:51:50 -0500 Received: from ozlabs.org ([103.22.144.67]:40171 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548AbdLFEvq (ORCPT ); Tue, 5 Dec 2017 23:51:46 -0500 From: Michael Ellerman To: Cyril Hrubis , Michal Hocko Cc: Kees Cook , Linux API , Khalid Aziz , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley Subject: Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE In-Reply-To: <20171201152640.GA3765@rei> References: <20171129144219.22867-1-mhocko@kernel.org> <20171130065835.dbw4ajh5q5whikhf@dhcp22.suse.cz> <20171201152640.GA3765@rei> Date: Wed, 06 Dec 2017 15:51:44 +1100 Message-ID: <87wp20e9wf.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cyril Hrubis writes: > Hi! >> > MAP_FIXED_UNIQUE >> > MAP_FIXED_ONCE >> > MAP_FIXED_FRESH >> >> Well, I can open a poll for the best name, but none of those you are >> proposing sound much better to me. Yeah, naming sucks... > > Given that MAP_FIXED replaces the previous mapping MAP_FIXED_NOREPLACE > would probably be a best fit. Yeah that could work. I prefer "no clobber" as I just suggested, because the existing MAP_FIXED doesn't politely "replace" a mapping, it destroys the current one - which you or another thread may be using - and clobbers it with the new one. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE Date: Wed, 06 Dec 2017 15:51:44 +1100 Message-ID: <87wp20e9wf.fsf@concordia.ellerman.id.au> References: <20171129144219.22867-1-mhocko@kernel.org> <20171130065835.dbw4ajh5q5whikhf@dhcp22.suse.cz> <20171201152640.GA3765@rei> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20171201152640.GA3765@rei> Sender: owner-linux-mm@kvack.org To: Cyril Hrubis , Michal Hocko Cc: Kees Cook , Linux API , Khalid Aziz , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley List-Id: linux-api@vger.kernel.org Cyril Hrubis writes: > Hi! >> > MAP_FIXED_UNIQUE >> > MAP_FIXED_ONCE >> > MAP_FIXED_FRESH >> >> Well, I can open a poll for the best name, but none of those you are >> proposing sound much better to me. Yeah, naming sucks... > > Given that MAP_FIXED replaces the previous mapping MAP_FIXED_NOREPLACE > would probably be a best fit. Yeah that could work. I prefer "no clobber" as I just suggested, because the existing MAP_FIXED doesn't politely "replace" a mapping, it destroys the current one - which you or another thread may be using - and clobbers it with the new one. cheers -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org