diff for duplicates of <87wp3axohi.fsf@kamboji.qca.qualcomm.com>
diff --git a/a/1.txt b/N1/1.txt
index d22633e..a0aa51a 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -2,28 +2,20 @@ Kalle Valo <kvalo@qca.qualcomm.com> writes:
> From: Alan Liu <alanliu@qca.qualcomm.com>
>
-> Add memory dump to the firmware crash data file which is provided to user=
- space
-> via devcoredump interface. This makes it easier for firmware engineers to=
- debug
+> Add memory dump to the firmware crash data file which is provided to user space
+> via devcoredump interface. This makes it easier for firmware engineers to debug
> firmware crashes.
>
-> Due to increased memory consumption the memory dump is disabled by defaul=
-t. To
+> Due to increased memory consumption the memory dump is disabled by default. To
> enable it make sure that bit 3 is set in coredump_mask module parameter:
>
-> modprobe ath10k_core coredump_mask=3D0xffffffff
+> modprobe ath10k_core coredump_mask=0xffffffff
>
-> When RAMDUMP is enabled a buffer for the dump is allocated with vmalloc d=
-uring
-> device probe. The actual memory layout is different in hardware versions =
-and
-> the layouts are defined in coredump.c. The memory is split to regions and=
-, to
-> get even finegrained control of what to copy, the region can split to sma=
-ller
-> sections as not all registers are readable (which could cause the whole s=
-ystem
+> When RAMDUMP is enabled a buffer for the dump is allocated with vmalloc during
+> device probe. The actual memory layout is different in hardware versions and
+> the layouts are defined in coredump.c. The memory is split to regions and, to
+> get even finegrained control of what to copy, the region can split to smaller
+> sections as not all registers are readable (which could cause the whole system
> to stall).
>
> Signed-off-by: Alan Liu <alanliu@qca.qualcomm.com>
@@ -35,18 +27,21 @@ ystem
> + /* To get IRAM dump, the host driver needs to switch target
> + * ram config from DRAM to IRAM.
> + */
-> + if (current_region->type =3D=3D ATH10K_MEM_REGION_TYPE_IRAM1 ||
-> + current_region->type =3D=3D ATH10K_MEM_REGION_TYPE_IRAM2) {
-> + shift =3D current_region->start >> 20;
+> + if (current_region->type == ATH10K_MEM_REGION_TYPE_IRAM1 ||
+> + current_region->type == ATH10K_MEM_REGION_TYPE_IRAM2) {
+> + shift = current_region->start >> 20;
> +
-> + ret =3D ath10k_pci_set_ram_config(ar, shift);
+> + ret = ath10k_pci_set_ram_config(ar, shift);
> + if (!ret) {
-> + ath10k_warn(ar, "failed to switch ram config to IRAM for section %s:=
- %d\n",
+> + ath10k_warn(ar, "failed to switch ram config to IRAM for section %s: %d\n",
> + current_region->name, ret);
A colleague noticed that there's a bug here, it should be "if (ret)".
I'll fix that in the next version.
---=20
-Kalle Valo=
\ No newline at end of file
+--
+Kalle Valo
+_______________________________________________
+ath10k mailing list
+ath10k@lists.infradead.org
+http://lists.infradead.org/mailman/listinfo/ath10k
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 865aa69..b987714 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -30,28 +30,20 @@
"\n",
"> From: Alan Liu <alanliu\@qca.qualcomm.com>\n",
">\n",
- "> Add memory dump to the firmware crash data file which is provided to user=\n",
- " space\n",
- "> via devcoredump interface. This makes it easier for firmware engineers to=\n",
- " debug\n",
+ "> Add memory dump to the firmware crash data file which is provided to user space\n",
+ "> via devcoredump interface. This makes it easier for firmware engineers to debug\n",
"> firmware crashes.\n",
">\n",
- "> Due to increased memory consumption the memory dump is disabled by defaul=\n",
- "t. To\n",
+ "> Due to increased memory consumption the memory dump is disabled by default. To\n",
"> enable it make sure that bit 3 is set in coredump_mask module parameter:\n",
">\n",
- "> modprobe ath10k_core coredump_mask=3D0xffffffff\n",
+ "> modprobe ath10k_core coredump_mask=0xffffffff\n",
">\n",
- "> When RAMDUMP is enabled a buffer for the dump is allocated with vmalloc d=\n",
- "uring\n",
- "> device probe. The actual memory layout is different in hardware versions =\n",
- "and\n",
- "> the layouts are defined in coredump.c. The memory is split to regions and=\n",
- ", to\n",
- "> get even finegrained control of what to copy, the region can split to sma=\n",
- "ller\n",
- "> sections as not all registers are readable (which could cause the whole s=\n",
- "ystem\n",
+ "> When RAMDUMP is enabled a buffer for the dump is allocated with vmalloc during\n",
+ "> device probe. The actual memory layout is different in hardware versions and\n",
+ "> the layouts are defined in coredump.c. The memory is split to regions and, to\n",
+ "> get even finegrained control of what to copy, the region can split to smaller\n",
+ "> sections as not all registers are readable (which could cause the whole system\n",
"> to stall).\n",
">\n",
"> Signed-off-by: Alan Liu <alanliu\@qca.qualcomm.com>\n",
@@ -63,21 +55,24 @@
"> +\t\t/* To get IRAM dump, the host driver needs to switch target\n",
"> +\t\t * ram config from DRAM to IRAM.\n",
"> +\t\t */\n",
- "> +\t\tif (current_region->type =3D=3D ATH10K_MEM_REGION_TYPE_IRAM1 ||\n",
- "> +\t\t current_region->type =3D=3D ATH10K_MEM_REGION_TYPE_IRAM2) {\n",
- "> +\t\t\tshift =3D current_region->start >> 20;\n",
+ "> +\t\tif (current_region->type == ATH10K_MEM_REGION_TYPE_IRAM1 ||\n",
+ "> +\t\t current_region->type == ATH10K_MEM_REGION_TYPE_IRAM2) {\n",
+ "> +\t\t\tshift = current_region->start >> 20;\n",
"> +\n",
- "> +\t\t\tret =3D ath10k_pci_set_ram_config(ar, shift);\n",
+ "> +\t\t\tret = ath10k_pci_set_ram_config(ar, shift);\n",
"> +\t\t\tif (!ret) {\n",
- "> +\t\t\t\tath10k_warn(ar, \"failed to switch ram config to IRAM for section %s:=\n",
- " %d\\n\",\n",
+ "> +\t\t\t\tath10k_warn(ar, \"failed to switch ram config to IRAM for section %s: %d\\n\",\n",
"> +\t\t\t\t\t current_region->name, ret);\n",
"\n",
"A colleague noticed that there's a bug here, it should be \"if (ret)\".\n",
"I'll fix that in the next version.\n",
"\n",
- "--=20\n",
- "Kalle Valo="
+ "-- \n",
+ "Kalle Valo\n",
+ "_______________________________________________\n",
+ "ath10k mailing list\n",
+ "ath10k\@lists.infradead.org\n",
+ "http://lists.infradead.org/mailman/listinfo/ath10k"
]
-204ddf680977d45cd9a0d12d9724952675504de3055146994d30b9a3ba3f69fe
+e85f9f1dc5a13faadf1ab07e5b5bc19a14232e75ada53b9eb7390f2e87f801da
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.