From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH] Revert "ASoC: simple-card-utils: enable "label" on asoc_simple_card_parse_card_name" Date: Tue, 29 Aug 2017 23:57:30 +0000 Message-ID: <87wp5morwb.wl%kuninori.morimoto.gx@renesas.com> References: <20170829153653.11766-1-l.stach@pengutronix.de> <87y3q2os2m.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from relmlie1.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa0.perex.cz (Postfix) with ESMTP id 0C98C266C52 for ; Wed, 30 Aug 2017 01:57:35 +0200 (CEST) In-Reply-To: <87y3q2os2m.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: alsa-devel@alsa-project.org, Liam Girdwood , Takashi Iwai , Mark Brown , kernel@pengutronix.de, patchwork-lst@pengutronix.de, Lucas Stach List-Id: alsa-devel@alsa-project.org Hi Lucas, again > > This commit breaks existing systems, as snd_soc_of_parse_card_name() doesn't > > return an error if the DT name property is missing, which would be required > > to hit the fallback path in the offending commit at all. > > > > Signed-off-by: Lucas Stach > > --- > > This should be fixed properly, but given the timing with the 4.13 release > > being really close, I opted for just reverting the offending commit. > > Sorry, but I don't understand your issue, and why it happens. > It tries to find "label" -> "[prefix]name" -> error. > The difference from previous version (tries "[prefix]name" -> error) > is just checking "label". > Do you know why it doesn't return error ? I missed your fixup patch. Sorry for my noise Best regards --- Kuninori Morimoto