From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga05.intel.com ([192.55.52.43]:26353 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753168AbdDKHC2 (ORCPT <rfc822;stable@vger.kernel.org>);
        Tue, 11 Apr 2017 03:02:28 -0400
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, nsekhar@ti.com, rogerq@ti.com,
        januszx.dziedzic@intel.com
Subject: Re: [PATCH v4.4, v4.9] usb: dwc3: gadget: delay unmap of bounced requests
In-Reply-To: <20170410152121.GA27662@kroah.com>
References: <20170410150007.19704-1-felipe.balbi@linux.intel.com> <20170410152121.GA27662@kroah.com>
Date: Tue, 11 Apr 2017 10:02:04 +0300
Message-ID: <87wparctqr.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Mon, Apr 10, 2017 at 06:00:07PM +0300, Felipe Balbi wrote:
>> From: Janusz Dziedzic <januszx.dziedzic@intel.com>
>>=20
>> commit de288e36fe33f7e06fa272bc8e2f85aa386d99aa upstream.
>>=20
>> In the case of bounced ep0 requests, we must delay DMA operation until
>> after ->complete() otherwise we might overwrite contents of req->buf.
>>=20
>> This caused problems with RNDIS gadget.
>>=20
>> Cc: <stable@vger.kernel.org> # v4.4 v4.9
>> Fixes: d62145929992 ("usb: dwc3: gadget: always unmap EP0 requests")
>> Signed-off-by: Janusz Dziedzic <januszx.dziedzic@intel.com>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> ---
>>=20
>> cherry-picked, fixed up and compile tested
>
> This only would apply to 4.9-stable, 4.4-stable it still fails:
> 	patching file drivers/usb/dwc3/gadget.c
> 	Hunk #1 succeeded at 1193 with fuzz 2 (offset 1019 lines).
> 	Hunk #2 FAILED at 183.
> 	Hunk #3 FAILED at 195.
> 	2 out of 3 hunks FAILED -- rejects in file drivers/usb/dwc3/gadget.c
>
> Care to send one for that tree?

dang, don't remember that code changing. Will do it shortly.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljsf2wACgkQzL64meEa
mQbXew//ap/+5RcAVvbzC7HbaW1hpeqh9IMwXM1vdcGqYLlNfZ2SghKtQCnaZ8Ti
jW017vP9fh/+IGpfBqCP+wSqQlFijIEAFbn0IW/sXULNqT2rehvIi18QP9BdHPuj
Op/ZtfvDRfOUpeYQlnTHWZgdnGprJL62sqM01uMzfgawcuqTNdMyLzqy0MCCQf3s
UAW0Py+LXLUPucDsjbE0tfLssn0BIJZjRUsphVRJicRz6eRyROVaHfi+qpYuCV9p
AxoEA8sV2vRZ6KoUaG9cDaVDwlSg4mGM8ZQ1pvEXeAv2+YvKb+DXTSDXcANTjplr
/h7o/Nt+GsGeyDBt2RCo0nHGMlsZFWqqVV0mCzXMLpdk2EPqffP7ya5sKKOq7QT6
WhTKojO20YVneEx/h8xQ1r5tjqCnt4WwkMDjrW3tLGKZsMTO+zUnNPXg9+Jfsjw4
WlMWabUDWEefpfkWmEJIHevdLvBEBKI55sUwFs3HHK//EMbkKCibSPs0qQQyo9u6
LhRvOG3zP0K+hfizLpBQaDVGGKILdAEhL5do3XcUhsJyxGwC2joVPy04Du4t4G8X
P5bcSgywFfJ5ECVezXQhmfYCcLaYv3vuhZPBrqJoEH+fCjCpafoxvOGrSVSxV3SG
6n5MU492jO0VxeeVvakWgb3vSplxKT8MDnCCaZmp8SCTCGVDMHU=
=PG0b
-----END PGP SIGNATURE-----
--=-=-=--