All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lzlib: depends on lua
Date: Thu, 22 Dec 2016 08:44:52 +0100	[thread overview]
Message-ID: <87wpes1k7f.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20161221234842.649a8277@free-electrons.com> (Thomas Petazzoni's message of "Wed, 21 Dec 2016 23:48:42 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Wed, 21 Dec 2016 17:22:44 -0300, gustavo.zacarias at free-electrons.com
 > wrote:
 >> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
 >> 
 >> It's missing the dependency on lua, hence when using the upcoming PPS
 >> support its staging directory isn't populated with the required
 >> dependencies resulting in build failure.
 >> 
 >> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

 > I'm probably missing something, but even without PPS we should have
 > seen build failures of this package, no?

 > Or because lzlib is after lua in alphabetic ordering, and nothing makes
 > lzlib built before lua due to dependencies, we were lucky enough?

Yes, I think it purely worked by chance because of the alphabetical
ordering.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2016-12-22  7:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 20:22 [Buildroot] [PATCH] lzlib: depends on lua gustavo.zacarias at free-electrons.com
2016-12-21 21:18 ` Peter Korsgaard
2016-12-21 22:48 ` Thomas Petazzoni
2016-12-21 22:56   ` Gustavo Zacarias
2016-12-22  7:44   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpes1k7f.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.