From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bhDTA-0007I5-Q1
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:19:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bhDT6-00015Q-J2
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:19:07 -0400
Received: from roura.ac.upc.es ([147.83.33.10]:52837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bhDT6-000157-7Z
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:19:04 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <20160905192304.373180.22164@ex-std-node742.prod.rhcloud.com>
	<87oa41mlzf.fsf@fimbulvetr.bsc.es>
	<0968a336-f276-633c-4d48-2e4fc81846be@redhat.com>
Date: Tue, 06 Sep 2016 12:19:01 +0200
In-Reply-To: <0968a336-f276-633c-4d48-2e4fc81846be@redhat.com> (Paolo
	Bonzini's message of "Tue, 6 Sep 2016 11:16:06 +0200")
Message-ID: <87wpip8h62.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Checkpatch false positives
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini writes:

> On 06/09/2016 11:11, Llu=C3=ADs Vilanova wrote:
>> no-reply  writes:
>>> Checking PATCH 1/6: hypertrace: Add documentation...
>>> ERROR: trailing whitespace
>>> #109: FILE: docs/hypertrace.txt:92:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #110: FILE: docs/hypertrace.txt:93:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #117: FILE: docs/hypertrace.txt:100:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #123: FILE: docs/hypertrace.txt:106:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #130: FILE: docs/hypertrace.txt:113:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #154: FILE: docs/hypertrace.txt:137:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #156: FILE: docs/hypertrace.txt:139:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #160: FILE: docs/hypertrace.txt:143:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #171: FILE: docs/hypertrace.txt:154:
>>> +    $
>>=20
>>> ERROR: trailing whitespace
>>> #181: FILE: docs/hypertrace.txt:164:
>>> +    $
>>=20
>>> total: 10 errors, 0 warnings, 236 lines checked
>>=20
>>> Your patch has style problems, please review.  If any of these errors
>>> are false positives report them to the maintainer, see
>>> CHECKPATCH in MAINTAINERS.
>>=20
>> The errors above are false positives. AFAIR, in .txt files empty lines i=
n code
>> examples need 4 white spaces to let the wiki properly render them as a s=
ingle
>> code example block.

> Right, can you make a patch for that?  It should recognize exactly 4
> patches and only apply to .txt and .md files.

Ok. I won't properly check this only applies to lines where surrounding tex=
t is
4-column-indented, though, so it can have false negatives.

Cheers,
  Lluis