From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbcADOGe (ORCPT ); Mon, 4 Jan 2016 09:06:34 -0500 Received: from mga09.intel.com ([134.134.136.24]:12962 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbcADOGc (ORCPT ); Mon, 4 Jan 2016 09:06:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,520,1444719600"; d="scan'208";a="885970626" From: Jani Nikula To: Insu Yun , daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu, Insu Yun Subject: Re: [PATCH v2] i915: correctly handling failed allocation In-Reply-To: <1451491169-35068-1-git-send-email-wuninsu@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1451491169-35068-1-git-send-email-wuninsu@gmail.com> User-Agent: Notmuch/0.21+33~g570c0ae (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 04 Jan 2016 16:06:03 +0200 Message-ID: <87wprp8mno.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Dec 2015, Insu Yun wrote: > Since devm_kzalloc can be failed, it needs to be checked > if not, NULL dereference could be happened. > > Signed-off-by: Insu Yun Pushed to drm-intel-next-queued, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > index a5e99ac..aa1f7bc 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > @@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id) > > /* This is cheating a bit with the cleanup. */ > vbt_panel = devm_kzalloc(dev->dev, sizeof(*vbt_panel), GFP_KERNEL); > + if (!vbt_panel) > + return NULL; > > vbt_panel->intel_dsi = intel_dsi; > drm_panel_init(&vbt_panel->panel); -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] i915: correctly handling failed allocation Date: Mon, 04 Jan 2016 16:06:03 +0200 Message-ID: <87wprp8mno.fsf@intel.com> References: <1451491169-35068-1-git-send-email-wuninsu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1451491169-35068-1-git-send-email-wuninsu@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: yeongjin.jang@gatech.edu, taesoo@gatech.edu, insu@gatech.edu, Insu Yun , changwoo@gatech.edu List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAzMCBEZWMgMjAxNSwgSW5zdSBZdW4gPHd1bmluc3VAZ21haWwuY29tPiB3cm90ZToK PiBTaW5jZSBkZXZtX2t6YWxsb2MgY2FuIGJlIGZhaWxlZCwgaXQgbmVlZHMgdG8gYmUgY2hlY2tl ZAo+IGlmIG5vdCwgTlVMTCBkZXJlZmVyZW5jZSBjb3VsZCBiZSBoYXBwZW5lZC4KPgo+IFNpZ25l ZC1vZmYtYnk6IEluc3UgWXVuIDx3dW5pbnN1QGdtYWlsLmNvbT4KClB1c2hlZCB0byBkcm0taW50 ZWwtbmV4dC1xdWV1ZWQsIHRoYW5rcyBmb3IgdGhlIHBhdGNoLgoKQlIsCkphbmkuCgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMgfCAyICsrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kc2lfcGFuZWxfdmJ0LmMKPiBpbmRleCBhNWU5OWFjLi5hYTFmN2JjIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYwo+IEBAIC02NjYsNiArNjY2 LDggQEAgc3RydWN0IGRybV9wYW5lbCAqdmJ0X3BhbmVsX2luaXQoc3RydWN0IGludGVsX2RzaSAq aW50ZWxfZHNpLCB1MTYgcGFuZWxfaWQpCj4gIAo+ICAJLyogVGhpcyBpcyBjaGVhdGluZyBhIGJp dCB3aXRoIHRoZSBjbGVhbnVwLiAqLwo+ICAJdmJ0X3BhbmVsID0gZGV2bV9remFsbG9jKGRldi0+ ZGV2LCBzaXplb2YoKnZidF9wYW5lbCksIEdGUF9LRVJORUwpOwo+ICsJaWYgKCF2YnRfcGFuZWwp Cj4gKwkJcmV0dXJuIE5VTEw7Cj4gIAo+ICAJdmJ0X3BhbmVsLT5pbnRlbF9kc2kgPSBpbnRlbF9k c2k7Cj4gIAlkcm1fcGFuZWxfaW5pdCgmdmJ0X3BhbmVsLT5wYW5lbCk7CgotLSAKSmFuaSBOaWt1 bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==