Re: [PATCH v2 0/3] mpls: ABI changes for security and correctness

[ebiederm@xmission.com (Eric W. Biederman)]

Robert Shearman <rshearma@brocade.com> writes:

> V2:
>  - don't treat loopback interfaces specially by enabling mpls by
>    default
>
> These changes make mpls not be enabled by default on all
> interfaces when in use for security, along with ensuring that a label
> not valid as an outgoing label can be added in mpls routes.
>
> This series contains three ABI/behaviour-affecting changes which have
> been split out from "[PATCH net-next v4 0/6] mpls: Behaviour-changing
> improvements" without any further modification. These changes need to
> be considered for 4.1 otherwise we'll be stuck with the current
> behaviour/ABI forever.

Thanks.

Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>

These patches all look good.  If these patches can make it into 4.1 so
we don't have a stable release without the new net/mpls/conf/<dev>/input
sysctl that would minimize disruption to users of the mpls code.

Eric

> Robert Shearman (3):
>   mpls: Per-device MPLS state
>   mpls: Per-device enabling of packet input
>   mpls: Prevent use of implicit NULL label as outgoing label
>
>  Documentation/networking/mpls-sysctl.txt |   9 +++
>  include/linux/netdevice.h                |   4 +
>  net/mpls/af_mpls.c                       | 125 ++++++++++++++++++++++++++++++-
>  net/mpls/internal.h                      |   6 ++
>  4 files changed, 141 insertions(+), 3 deletions(-)