From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YhgOe-0000em-RV
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 11:35:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YhgOb-0006qx-Ad
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 11:35:36 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:35549 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YhgOa-0006qq-Pk
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 11:35:33 -0400
References: <1428777292-24628-1-git-send-email-afaerber@suse.de>
	<1428777292-24628-5-git-send-email-afaerber@suse.de>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1428777292-24628-5-git-send-email-afaerber@suse.de>
Date: Mon, 13 Apr 2015 16:35:48 +0100
Message-ID: <87wq1gjb1n.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.3? 4/7] tests/tcg: Fix running x86_64
	tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net


Andreas Färber <afaerber@suse.de> writes:

> When ARCH != i386, the wrong test target was being added to the list of
> tests to run. Fix this to have test-x86_64 run as well.
>
> Note that test-x86_64 produces two build warnings on gcc 4.8.3, but we
> don't use -Werror for these tests:
>
>   test-i386.c:2110:1: warning: specifying vector types with __attribute__ ((mode)) is deprecated [-Wattributes]
>    typedef int __m64 __attribute__ ((__mode__ (__V2SI__)));
>   test-i386.c:2110:1: warning: use __attribute__ ((vector_size)) instead [-Wattributes]
>
>   test-i386.c:2111:1: warning: specifying vector types with __attribute__ ((mode)) is deprecated [-Wattributes]
>    typedef float __m128 __attribute__ ((__mode__(__V4SF__)));
>   test-i386.c:2111:1: warning: use __attribute__ ((vector_size)) instead [-Wattributes]
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/tcg/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
> index d79e0bb..ab1055f 100644
> --- a/tests/tcg/Makefile
> +++ b/tests/tcg/Makefile
> @@ -29,7 +29,7 @@ I386_TESTS=hello-i386 \
>  
>  # native i386 compilers sometimes are not biarch.  assume cross-compilers are
>  ifneq ($(ARCH),i386)
> -I386_TESTS+=run-test-x86_64
> +I386_TESTS+=test-x86_64
>  endif
>  
>  TESTS = test_path

-- 
Alex Bennée