From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbbBKGgC (ORCPT ); Wed, 11 Feb 2015 01:36:02 -0500 Received: from ozlabs.org ([103.22.144.67]:40773 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbbBKGf6 (ORCPT ); Wed, 11 Feb 2015 01:35:58 -0500 From: Rusty Russell To: Jan Kiszka , Andrew Morton , linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Jason Wessel , kgdb-bugreport@lists.sourceforge.net, Andi Kleen , Ben Widawsky , Borislav Petkov Subject: Re: [PATCH v12 06/28] module: Do not inline do_init_module In-Reply-To: References: User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 11 Feb 2015 10:29:48 +1030 Message-ID: <87wq3pb9mz.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jan Kiszka writes: > This provides a reliable breakpoint target, required for automatic > symbol loading via the gdb helper command 'lx-symbols'. > > CC: Rusty Russell Acked-by: Rusty Russell Thanks, Rusty. > Signed-off-by: Jan Kiszka > --- > kernel/module.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/kernel/module.c b/kernel/module.c > index d856e96..2df6cec 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3011,8 +3011,13 @@ static void do_free_init(struct rcu_head *head) > kfree(m); > } > > -/* This is where the real work happens */ > -static int do_init_module(struct module *mod) > +/* > + * This is where the real work happens. > + * > + * Keep it uninlined to provide a reliable breakpoint target, e.g. for the gdb > + * helper command 'lx-symbols'. > + */ > +static noinline int do_init_module(struct module *mod) > { > int ret = 0; > struct mod_initfree *freeinit; > -- > 2.1.4