From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:14344 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbaGXJp3 (ORCPT ); Thu, 24 Jul 2014 05:45:29 -0400 From: Kalle Valo To: Michal Kazior CC: Simon Wunderlich , Mathias Kretschmer , linux-wireless , "ath10k@lists.infradead.org" , "Giori, Kathy" , Sven Eckelmann Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature References: <87mwc0ro8i.fsf@kamboji.qca.qualcomm.com> <1406136773-19957-1-git-send-email-sw@simonwunderlich.de> <871ttbrtp8.fsf@kamboji.qca.qualcomm.com> Date: Thu, 24 Jul 2014 12:45:21 +0300 In-Reply-To: (Michal Kazior's message of "Thu, 24 Jul 2014 11:34:12 +0200") Message-ID: <87wqb3qedq.fsf@kamboji.qca.qualcomm.com> (sfid-20140724_114532_362729_1ABF92EF) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > On 24 July 2014 11:29, Kalle Valo wrote: >> Simon Wunderlich writes: >> >>> Adds the spectral scan feature for ath10k. The spectral scan is triggered by >>> configuring a mode through a debugfs control file. Samples can be gathered via >>> another relay debugfs file. >>> > [...] >>> @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar) >>> else >>> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1; >>> >>> - INIT_LIST_HEAD(&ar->arvifs); >>> - >>> if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) { >>> ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n", >>> ar->hw_params.name, >>> @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev, >>> INIT_WORK(&ar->register_work, ath10k_core_register_work); >>> INIT_WORK(&ar->restart_work, ath10k_core_restart); >>> >>> + INIT_LIST_HEAD(&ar->arvifs); >> >> I'm a bit suspicious about this, why is it needed? > > Good hunch. ar->arvifs must be re-initialized in core_start for > recovery to work correctly. Thanks for the confirmation. I think I found a way to rework the spectral initialisation which also fixes this issue, I'll send a new version later today. Need to run some tests first. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XAFay-0007i0-Ei for ath10k@lists.infradead.org; Thu, 24 Jul 2014 09:45:52 +0000 From: Kalle Valo Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature References: <87mwc0ro8i.fsf@kamboji.qca.qualcomm.com> <1406136773-19957-1-git-send-email-sw@simonwunderlich.de> <871ttbrtp8.fsf@kamboji.qca.qualcomm.com> Date: Thu, 24 Jul 2014 12:45:21 +0300 In-Reply-To: (Michal Kazior's message of "Thu, 24 Jul 2014 11:34:12 +0200") Message-ID: <87wqb3qedq.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: Simon Wunderlich , Mathias Kretschmer , linux-wireless , "ath10k@lists.infradead.org" , "Giori, Kathy" , Sven Eckelmann Michal Kazior writes: > On 24 July 2014 11:29, Kalle Valo wrote: >> Simon Wunderlich writes: >> >>> Adds the spectral scan feature for ath10k. The spectral scan is triggered by >>> configuring a mode through a debugfs control file. Samples can be gathered via >>> another relay debugfs file. >>> > [...] >>> @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar) >>> else >>> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1; >>> >>> - INIT_LIST_HEAD(&ar->arvifs); >>> - >>> if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) { >>> ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n", >>> ar->hw_params.name, >>> @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev, >>> INIT_WORK(&ar->register_work, ath10k_core_register_work); >>> INIT_WORK(&ar->restart_work, ath10k_core_restart); >>> >>> + INIT_LIST_HEAD(&ar->arvifs); >> >> I'm a bit suspicious about this, why is it needed? > > Good hunch. ar->arvifs must be re-initialized in core_start for > recovery to work correctly. Thanks for the confirmation. I think I found a way to rework the spectral initialisation which also fixes this issue, I'll send a new version later today. Need to run some tests first. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k