From: Kan-Ru Chen <kanru@0xlab.org>
To: linux-omap@vger.kernel.org
Cc: Kan-Ru Chen <kanru@0xlab.org>, Thomas Weber <weber@corscience.de>
Subject: Re: [PATCH 1/2] Enable DVI-D output for Devkit8000
Date: Wed, 07 Apr 2010 16:26:00 +0800 [thread overview]
Message-ID: <87wrwjr7mv.fsf@anar.kanru.info> (raw)
In-Reply-To: <1270613370-4135-1-git-send-email-kanru@0xlab.org>
On Wed, 7 Apr 2010 12:09:29 +0800, Kan-Ru Chen <kanru@0xlab.org> wrote:
> @@ -283,6 +289,12 @@ static int devkit8000_twl_gpio_setup(struct device *dev,
> /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
> gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
>
> + /* gpio + 7 is "DVI_PUD" (out, active low) */
> + devkit8000_dvi_device.reset_gpio = gpio + 7;
> + gpio_request(devkit8000_dvi_device.reset_gpio, "DVI_PUD");
> + /* Disable until needed */
> + gpio_direction_output(devkit8000_dvi_device.reset_gpio, 1);
> +
> return 0;
> }
Sorry for the noise, it seems I misconfigured this pin. It's actually
active high. So the initial value should be 0 to disable it. I will
prepare a new patch about this.
And seems the second patch doesn't effect the LCD state at all. I have
no idea, but the patch can be dropped.
Cheers,
Kanru
--
Kan-Ru Chen | http://kanru.info
Q: Why are my replies five sentences or less?
A: http://five.sentenc.es/
next prev parent reply other threads:[~2010-04-07 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 4:09 [PATCH 1/2] Enable DVI-D output for Devkit8000 Kan-Ru Chen
2010-04-07 4:09 ` [PATCH 2/2] Setup LCD reset " Kan-Ru Chen
2010-04-07 8:26 ` Kan-Ru Chen [this message]
2010-04-07 8:34 [PATCH 1/2] Enable DVI-D output " Kan-Ru Chen
2010-04-09 13:07 ` Thomas Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrwjr7mv.fsf@anar.kanru.info \
--to=kanru@0xlab.org \
--cc=linux-omap@vger.kernel.org \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.