All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>, David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, stable@vger.kernel.org,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] assoc_array: Fix BUG_ON during garbage collect
Date: Wed, 01 Jun 2022 16:03:12 -0700	[thread overview]
Message-ID: <87y1ygyojz.fsf@stepbren-lnx.us.oracle.com> (raw)
In-Reply-To: <YpfrLUknlmcvwNzY@sol.localdomain>

Eric Biggers <ebiggers@kernel.org> writes:

> On Thu, May 19, 2022 at 09:50:30AM +0100, David Howells wrote:
>> diff --git a/lib/assoc_array.c b/lib/assoc_array.c
>> index 079c72e26493..ca0b4f360c1a 100644
>> --- a/lib/assoc_array.c
>> +++ b/lib/assoc_array.c
>
> Where are the tests for this file?

As of today there are none:

$ grep -lr assoc_array
lib/assoc_array.c
lib/Makefile
lib/Kconfig
arch/powerpc/mm/numa.c
arch/powerpc/platforms/pseries/hotplug-memory.c
Documentation/core-api/index.rst
Documentation/core-api/assoc_array.rst
Documentation/translations/zh_CN/core-api/index.rst
Documentation/translations/zh_CN/core-api/assoc_array.rst
include/linux/assoc_array.h
include/linux/key.h
include/linux/assoc_array_priv.h
include/keys/keyring-type.h
security/keys/internal.h
security/keys/key.c
security/keys/keyring.c
security/keys/request_key.c

The assoc_array code is easy to get up and running in userspace (see the
reproducer for this bug). So testing it would be feasible with some sort
of userspace runner (KUnit?). Seems it hasn't been done yet.

Stephen

>
> - Eric

  reply	other threads:[~2022-06-01 23:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  8:50 [PATCH] assoc_array: Fix BUG_ON during garbage collect David Howells
2022-05-19 22:17 ` Jarkko Sakkinen
2022-05-23 17:39 ` Stephen Brennan
2022-06-01 21:59 ` Stephen Brennan
2022-06-02  1:31   ` Linus Torvalds
2022-06-02 17:05     ` Stephen Brennan
2022-06-01 22:41 ` Eric Biggers
2022-06-01 23:03   ` Stephen Brennan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-05-11 22:55 Stephen Brennan
2022-05-11 23:15 ` Stephen Brennan
2022-05-12 21:49 ` Stephen Brennan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1ygyojz.fsf@stepbren-lnx.us.oracle.com \
    --to=stephen.s.brennan@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.