From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF99C433EF for ; Mon, 6 Sep 2021 01:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9271260F3A for ; Mon, 6 Sep 2021 01:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238622AbhIFByw (ORCPT ); Sun, 5 Sep 2021 21:54:52 -0400 Received: from mga03.intel.com ([134.134.136.65]:63775 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238511AbhIFByv (ORCPT ); Sun, 5 Sep 2021 21:54:51 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="219916175" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="219916175" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:53:47 -0700 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="536346047" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:53:41 -0700 From: "Huang, Ying" To: kernel test robot , Rui Zhang , Chen Yu , Len Brown , "Rafael J. Wysocki" Cc: Andrew Morton , 0day robot , Yang Shi , Zi Yan , Michal Hocko , Wei Xu , Oscar Salvador , David Rientjes , Dan Williams , David Hildenbrand , Greg Thelen , Keith Busch , Yang Shi , LKML , , , , , , , Subject: Re: [mm/migrate] 9eeb73028c: stress-ng.memhotplug.ops_per_sec -53.8% regression References: <20210905135932.GE15026@xsang-OptiPlex-9020> Date: Mon, 06 Sep 2021 09:53:39 +0800 In-Reply-To: <20210905135932.GE15026@xsang-OptiPlex-9020> (kernel test robot's message of "Sun, 5 Sep 2021 21:59:33 +0800") Message-ID: <87y28aii58.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernel test robot writes: > Greeting, > > FYI, we noticed a -53.8% regression of stress-ng.memhotplug.ops_per_sec due to commit: > > > commit: 9eeb73028cfb54eb06efe87c50cc014d3f1ff43e ("[patch 174/212] mm/migrate: update node demotion order on hotplug events") > url: https://github.com/0day-ci/linux/commits/Andrew-Morton/ia64-fix-typo-in-a-comment/20210903-065028 > > > in testcase: stress-ng > on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz with 192G memory > with following parameters: > > nr_threads: 10% > disk: 1HDD > testtime: 60s > fs: ext4 > class: os > test: memhotplug > cpufreq_governor: performance > ucode: 0x5003006 > Because we added some operations during online/offline CPU, it's expected that the performance of online/offline CPU will decrease. In most cases, the performance of CPU hotplug isn't a big problem. But then I remembers that the performance of the CPU hotplug may influence suspend/resume performance :-( It appears that it is easy and reasonable to enclose the added operations inside #ifdef CONFIG_NUMA. Is this sufficient to restore the performance of suspend/resume? Best Regards, Huang, Ying From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E403BC433EF for ; Mon, 6 Sep 2021 01:54:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 680FB60F6D for ; Mon, 6 Sep 2021 01:54:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 680FB60F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 908016B0071; Sun, 5 Sep 2021 21:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B7AA6B0072; Sun, 5 Sep 2021 21:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A67F6B0073; Sun, 5 Sep 2021 21:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id 6E66D6B0071 for ; Sun, 5 Sep 2021 21:54:02 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 10D0E29E17 for ; Mon, 6 Sep 2021 01:54:02 +0000 (UTC) X-FDA: 78555477924.38.44B7D33 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf27.hostedemail.com (Postfix) with ESMTP id 36A9A700009E for ; Mon, 6 Sep 2021 01:54:00 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="217994008" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="217994008" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:53:47 -0700 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="536346047" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:53:41 -0700 From: "Huang, Ying" To: kernel test robot , Rui Zhang , Chen Yu , Len Brown , "Rafael J. Wysocki" Cc: Andrew Morton , 0day robot , Yang Shi , Zi Yan , Michal Hocko , Wei Xu , Oscar Salvador , David Rientjes , Dan Williams , David Hildenbrand , Greg Thelen , Keith Busch , Yang Shi , LKML , , , , , , , Subject: Re: [mm/migrate] 9eeb73028c: stress-ng.memhotplug.ops_per_sec -53.8% regression References: <20210905135932.GE15026@xsang-OptiPlex-9020> Date: Mon, 06 Sep 2021 09:53:39 +0800 In-Reply-To: <20210905135932.GE15026@xsang-OptiPlex-9020> (kernel test robot's message of "Sun, 5 Sep 2021 21:59:33 +0800") Message-ID: <87y28aii58.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf27.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=ying.huang@intel.com X-Stat-Signature: mme5ezh6stga1qe88aorscmybf3zpgqw X-Rspamd-Queue-Id: 36A9A700009E X-Rspamd-Server: rspam04 X-HE-Tag: 1630893240-301202 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: kernel test robot writes: > Greeting, > > FYI, we noticed a -53.8% regression of stress-ng.memhotplug.ops_per_sec due to commit: > > > commit: 9eeb73028cfb54eb06efe87c50cc014d3f1ff43e ("[patch 174/212] mm/migrate: update node demotion order on hotplug events") > url: https://github.com/0day-ci/linux/commits/Andrew-Morton/ia64-fix-typo-in-a-comment/20210903-065028 > > > in testcase: stress-ng > on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz with 192G memory > with following parameters: > > nr_threads: 10% > disk: 1HDD > testtime: 60s > fs: ext4 > class: os > test: memhotplug > cpufreq_governor: performance > ucode: 0x5003006 > Because we added some operations during online/offline CPU, it's expected that the performance of online/offline CPU will decrease. In most cases, the performance of CPU hotplug isn't a big problem. But then I remembers that the performance of the CPU hotplug may influence suspend/resume performance :-( It appears that it is easy and reasonable to enclose the added operations inside #ifdef CONFIG_NUMA. Is this sufficient to restore the performance of suspend/resume? Best Regards, Huang, Ying From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5573585314110285843==" MIME-Version: 1.0 From: Huang, Ying To: lkp@lists.01.org Subject: Re: [mm/migrate] 9eeb73028c: stress-ng.memhotplug.ops_per_sec -53.8% regression Date: Mon, 06 Sep 2021 09:53:39 +0800 Message-ID: <87y28aii58.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <20210905135932.GE15026@xsang-OptiPlex-9020> List-Id: --===============5573585314110285843== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable kernel test robot writes: > Greeting, > > FYI, we noticed a -53.8% regression of stress-ng.memhotplug.ops_per_sec d= ue to commit: > > > commit: 9eeb73028cfb54eb06efe87c50cc014d3f1ff43e ("[patch 174/212] mm/mig= rate: update node demotion order on hotplug events") > url: https://github.com/0day-ci/linux/commits/Andrew-Morton/ia64-fix-typo= -in-a-comment/20210903-065028 > > > in testcase: stress-ng > on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Gold 6252 CPU @ 2.= 10GHz with 192G memory > with following parameters: > > nr_threads: 10% > disk: 1HDD > testtime: 60s > fs: ext4 > class: os > test: memhotplug > cpufreq_governor: performance > ucode: 0x5003006 > Because we added some operations during online/offline CPU, it's expected that the performance of online/offline CPU will decrease. In most cases, the performance of CPU hotplug isn't a big problem. But then I remembers that the performance of the CPU hotplug may influence suspend/resume performance :-( It appears that it is easy and reasonable to enclose the added operations inside #ifdef CONFIG_NUMA. Is this sufficient to restore the performance of suspend/resume? Best Regards, Huang, Ying --===============5573585314110285843==--