From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA86189F43 for ; Thu, 5 Aug 2021 07:25:08 +0000 (UTC) Date: Thu, 05 Aug 2021 00:18:18 -0700 Message-ID: <87y29gs6kl.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210726200026.4815-17-zbigniew.kempczynski@intel.com> References: <20210726200026.4815-1-zbigniew.kempczynski@intel.com> <20210726200026.4815-17-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t v3 16/52] tests/gem_ctx_param: Adopt to use allocator List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org List-ID: On Mon, 26 Jul 2021 12:59:50 -0700, Zbigniew Kempczy=F1ski wrote: > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index c795f1b45..11bc08e36 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -165,6 +165,7 @@ static void test_vm(int i915) > int err; > uint32_t parent, child; > igt_spin_t *spin; > + uint64_t ahnd; > > /* > * Proving 2 contexts share the same GTT is quite tricky as we have no > @@ -190,7 +191,8 @@ static void test_vm(int i915) > > /* Test that we can't set the VM after we've done an execbuf */ > arg.ctx_id =3D gem_context_create(i915); > - spin =3D igt_spin_new(i915, .ctx_id =3D arg.ctx_id); > + ahnd =3D get_reloc_ahnd(i915, arg.ctx_id); > + spin =3D igt_spin_new(i915, .ahnd =3D ahnd, .ctx_id =3D arg.ctx_id); > igt_spin_free(i915, spin); > arg.value =3D gem_vm_create(i915); > err =3D __gem_context_set_param(i915, &arg); > @@ -202,7 +204,7 @@ static void test_vm(int i915) > child =3D gem_context_create(i915); > > /* Create a background spinner to keep the engines busy */ > - spin =3D igt_spin_new(i915); > + spin =3D igt_spin_new(i915, .ahnd =3D ahnd); > for (int i =3D 0; i < 16; i++) { > spin->execbuf.rsvd1 =3D gem_context_create(i915); > __gem_context_set_priority(i915, spin->execbuf.rsvd1, 1023); > @@ -259,6 +261,7 @@ static void test_vm(int i915) > igt_spin_free(i915, spin); > gem_sync(i915, batch.handle); > gem_close(i915, batch.handle); > + put_ahnd(ahnd); I think this should work even thought the context against which ahnd has been created has been destroyed after the first spin_free, but please check: Reviewed-by: Ashutosh Dixit