From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89A046E882 for ; Wed, 23 Jun 2021 03:11:23 +0000 (UTC) Date: Tue, 22 Jun 2021 20:10:53 -0700 Message-ID: <87y2b1jmwy.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210617191516.577394-27-jason@jlekstrand.net> References: <20210617191256.577244-1-jason@jlekstrand.net> <20210617191516.577394-27-jason@jlekstrand.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 76/79] tests/i915/gem_ctx_param: Add a couple invalid PARAM_VM cases List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, 17 Jun 2021 12:15:13 -0700, Jason Ekstrand wrote: > Please add SOB, otherwise: Reviewed-by: Ashutosh Dixit > --- > tests/i915/gem_ctx_param.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index 7fba37cbd..c795f1b45 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -181,6 +181,23 @@ static void test_vm(int i915) > gem_context_destroy(i915, arg.ctx_id); > igt_require(err == -ENOENT); > > + /* Test that we can't set the VM on ctx0 */ > + arg.ctx_id = 0; > + arg.value = gem_vm_create(i915); > + err = __gem_context_set_param(i915, &arg); > + gem_vm_destroy(i915, arg.value); > + igt_assert_eq(err, -EINVAL); > + > + /* Test that we can't set the VM after we've done an execbuf */ > + arg.ctx_id = gem_context_create(i915); > + spin = igt_spin_new(i915, .ctx_id = arg.ctx_id); > + igt_spin_free(i915, spin); > + arg.value = gem_vm_create(i915); > + err = __gem_context_set_param(i915, &arg); > + gem_context_destroy(i915, arg.ctx_id); > + gem_vm_destroy(i915, arg.value); > + igt_assert_eq(err, -EINVAL); > + > parent = gem_context_create(i915); > child = gem_context_create(i915); > > -- > 2.31.1 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev