From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/bios: tidy up child device debug logging
Date: Mon, 01 Feb 2021 12:33:52 +0200 [thread overview]
Message-ID: <87y2g8gjqn.fsf@intel.com> (raw)
In-Reply-To: <YBQoi1ACbfpQi7AV@intel.com>
On Fri, 29 Jan 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Jan 27, 2021 at 10:45:34AM +0200, Jani Nikula wrote:
>> Make the child device details easier to read by turning this:
>>
>> [drm:parse_ddi_port [i915]] Port B VBT info: CRT:0 DVI:1 HDMI:1 DP:0 eDP:0 LSPCON:0 USB-Type-C:0 TBT:0 DSC:0
>> [drm:parse_ddi_port [i915]] VBT HDMI level shift for port B: 8
>> [drm:parse_ddi_port [i915]] VBT DP max link rate for port B: 810000
>> [drm:parse_ddi_port [i915]] Port C VBT info: CRT:0 DVI:1 HDMI:1 DP:1 eDP:0 LSPCON:0 USB-Type-C:0 TBT:0 DSC:0
>> [drm:parse_ddi_port [i915]] VBT HDMI level shift for port C: 8
>> [drm:parse_ddi_port [i915]] VBT (e)DP boost level for port C: 3
>> [drm:parse_ddi_port [i915]] VBT HDMI boost level for port C: 1
>> [drm:parse_ddi_port [i915]] VBT DP max link rate for port C: 810000
>>
>> into this:
>>
>> [drm:parse_ddi_port [i915]] Port B VBT info: CRT:0 DVI:1 HDMI:1 DP:0 eDP:0 LSPCON:0 USB-Type-C:0 TBT:0 DSC:0
>> [drm:parse_ddi_port [i915]] Port B VBT HDMI level shift: 8
>> [drm:parse_ddi_port [i915]] Port B VBT DP max link rate: 810000
>> [drm:parse_ddi_port [i915]] Port C VBT info: CRT:0 DVI:1 HDMI:1 DP:1 eDP:0 LSPCON:0 USB-Type-C:0 TBT:0 DSC:0
>> [drm:parse_ddi_port [i915]] Port C VBT HDMI level shift: 8
>> [drm:parse_ddi_port [i915]] Port C VBT (e)DP boost level: 3
>> [drm:parse_ddi_port [i915]] Port C VBT HDMI boost level: 1
>> [drm:parse_ddi_port [i915]] Port C VBT DP max link rate: 810000
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 04337ac6f8c4..796d6be0ba5d 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1829,7 +1829,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>> /* The VBT HDMI level shift values match the table we have. */
>> u8 hdmi_level_shift = child->hdmi_level_shifter_value;
>> drm_dbg_kms(&dev_priv->drm,
>> - "VBT HDMI level shift for port %c: %d\n",
>> + "Port %c VBT HDMI level shift: %d\n",
>> port_name(port),
>> hdmi_level_shift);
>> info->hdmi_level_shift = hdmi_level_shift;
>> @@ -1856,7 +1856,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>>
>> if (max_tmds_clock)
>> drm_dbg_kms(&dev_priv->drm,
>> - "VBT HDMI max TMDS clock for port %c: %d kHz\n",
>> + "Port %c VBT HDMI max TMDS clock: %d kHz\n",
>> port_name(port), max_tmds_clock);
>> info->max_tmds_clock = max_tmds_clock;
>> }
>> @@ -1865,11 +1865,11 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>> if (bdb_version >= 196 && child->iboost) {
>> info->dp_boost_level = translate_iboost(child->dp_iboost_level);
>> drm_dbg_kms(&dev_priv->drm,
>> - "VBT (e)DP boost level for port %c: %d\n",
>> + "Port %c VBT (e)DP boost level: %d\n",
>> port_name(port), info->dp_boost_level);
>> info->hdmi_boost_level = translate_iboost(child->hdmi_iboost_level);
>> drm_dbg_kms(&dev_priv->drm,
>> - "VBT HDMI boost level for port %c: %d\n",
>> + "Port %c VBT HDMI boost level: %d\n",
>> port_name(port), info->hdmi_boost_level);
>> }
>>
>> @@ -1891,7 +1891,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>> break;
>> }
>> drm_dbg_kms(&dev_priv->drm,
>> - "VBT DP max link rate for port %c: %d\n",
>> + "Port %c VBT DP max link rate: %d\n",
>> port_name(port), info->dp_max_link_rate);
>> }
>>
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-02-01 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 8:45 [Intel-gfx] [PATCH] drm/i915/bios: tidy up child device debug logging Jani Nikula
2021-01-27 13:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-01-27 13:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-27 16:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-29 15:23 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2021-02-01 10:33 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2g8gjqn.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.