[PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

[PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

[Kurt Kanzenbach]

The unit address should be 1e, because the unit address is supposed
to be in hexadecimal.

Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
 Documentation/devicetree/bindings/net/dsa/b53.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
index 80437b2fc935..3bb4e1086913 100644
--- a/Documentation/devicetree/bindings/net/dsa/b53.txt
+++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
@@ -104,7 +104,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		switch0: ethernet-switch@30 {
+		switch0: ethernet-switch@1e {
 			compatible = "brcm,bcm53125";
 			reg = <30>;
 			#address-cells = <1>;
-- 
2.20.1

[PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

[Kurt Kanzenbach]

There is no such property as duplex-full. It's called full-duplex. Leading to
reduced speed when using the example as base for a real device tree.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
 Documentation/devicetree/bindings/net/dsa/b53.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
index 3bb4e1086913..f1487a751b1a 100644
--- a/Documentation/devicetree/bindings/net/dsa/b53.txt
+++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
@@ -95,7 +95,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
 
 		fixed-link {
 			speed = <1000>;
-			duplex-full;
+			full-duplex;
 		};
 	};
 
@@ -129,7 +129,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
 					label = "cable-modem";
 					fixed-link {
 						speed = <1000>;
-						duplex-full;
+						full-duplex;
 					};
 					phy-mode = "rgmii-txid";
 				};
@@ -139,7 +139,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
 					label = "cpu";
 					fixed-link {
 						speed = <1000>;
-						duplex-full;
+						full-duplex;
 					};
 					phy-mode = "rgmii-txid";
 					ethernet = <&eth0>;
-- 
2.20.1

Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

[Florian Fainelli]

On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote:
> There is no such property as duplex-full. It's called full-duplex. Leading to
> reduced speed when using the example as base for a real device tree.

Doh, thanks for correcting this. Would you want to make this a YAML 
binding at some point? I can take care of it if you do not have time to 
do it.

> 
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

[Kurt Kanzenbach]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

On Sat Oct 03 2020, Florian Fainelli wrote:
> On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote:
>> There is no such property as duplex-full. It's called full-duplex. Leading to
>> reduced speed when using the example as base for a real device tree.
>
> Doh, thanks for correcting this. Would you want to make this a YAML 
> binding at some point? I can take care of it if you do not have time to 
> do it.

Actually I have started to convert the DSA bindings to YAML, but ran out
of time very quickly. Unfortunately the b53 wasn't one of them I've
converted already. So, you can go ahead.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Fix full duplex in example

[David Miller]

From: Kurt Kanzenbach <kurt@linutronix.de>
Date: Sat,  3 Oct 2020 11:30:51 +0200

> There is no such property as duplex-full. It's called full-duplex. Leading to
> reduced speed when using the example as base for a real device tree.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Applied.

Re: [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

[Florian Fainelli]

On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote:
> The unit address should be 1e, because the unit address is supposed
> to be in hexadecimal.
> 
> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Specify unit address in hex

[David Miller]

From: Kurt Kanzenbach <kurt@linutronix.de>
Date: Sat,  3 Oct 2020 11:30:50 +0200

> The unit address should be 1e, because the unit address is supposed
> to be in hexadecimal.
> 
> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Applied.