From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417EEC433DF for ; Wed, 5 Aug 2020 11:35:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D15F22D00 for ; Wed, 5 Aug 2020 11:35:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KMzOCMV+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D15F22D00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3HhF-00084V-6F for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 07:35:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3Hgb-0007Zh-4F for qemu-devel@nongnu.org; Wed, 05 Aug 2020 07:34:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3HgY-00053L-RJ for qemu-devel@nongnu.org; Wed, 05 Aug 2020 07:34:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596627256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wpOdlamihXxD8YGglWtePzUheRWV5FDcsICCim1RROk=; b=KMzOCMV+aykgfIqfp3IY4/5hntjB40MieT3ojk6h30fBx6PxFj/W+ePigMwN81zJqTX6kR 6ly8Ewhir8SnagXeR58wwoTit7voMsLpAAlgD0zfBXP49vvzlTAXZhez490zTC6Zcw/k1C baxg3VG3c0vvZKQ0ZdWQTXUiwzSpdpc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-JLyMORg-NzyJ5lLW6nzq3g-1; Wed, 05 Aug 2020 07:34:15 -0400 X-MC-Unique: JLyMORg-NzyJ5lLW6nzq3g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E5E2101C8A0; Wed, 5 Aug 2020 11:34:14 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D578D5D9DC; Wed, 5 Aug 2020 11:34:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6CA8F1141D60; Wed, 5 Aug 2020 13:34:12 +0200 (CEST) From: Markus Armbruster To: Kevin Wolf Subject: Re: [PATCH v6 00/12] monitor: Optionally run handlers in coroutines References: <20200528153742.274164-1-kwolf@redhat.com> <87d046d5k1.fsf@dusky.pond.sub.org> Date: Wed, 05 Aug 2020 13:34:12 +0200 In-Reply-To: <87d046d5k1.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Tue, 04 Aug 2020 13:16:46 +0200") Message-ID: <87y2mtpbrf.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 06:27:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@gmail.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > I let this series slide to get my Error API rework done, along with much > else. My sincere apologies! > > Unsurprisingly, it needs a rebase now. I suggest to let me review it as > is first. I'm done with v6. Summary: * A few trivial things to correct here and there. * A few ideas to improve things in relatively minor ways. * PATCH 03 looks "why bother" to me until PATCH 09 makes me suspect you did the former to enable the latter. If you had captured that in your commit message back then, like you did for the similar PATCH 05, I wouldn't be scratching my head now :) * I dislike PATCH 06, and would like to explore an alternative idea. * PATCH 08 makes hairy monitor code even hairier, but I don't have better ideas. * I don't feel comfortable as a sole reviewer of the AIO magic in PATCH 10-12. Let's ask Stefan for an eye-over. I'd like to proceed as follows. You rebase, and address "easy" review comments (you decide what's easy). Post as v7, cc'ing Stefan for the AIO magic and David Gilbert for HMP. While they review (hopefully), I explore a replacement for PATCH 06. And then we touch bases and decide how to get this thing wrapped. Okay?